Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2845843002: [recipes.py] move refs arg parsing to its module (Closed)

Created:
3 years, 8 months ago by iannucci
Modified:
3 years, 7 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M recipe_engine/refs.py View 1 chunk +17 lines, -1 line 1 comment Download
M recipes.py View 1 2 4 chunks +2 lines, -21 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (15 generated)
iannucci
3 years, 8 months ago (2017-04-27 00:44:38 UTC) #1
dnj
lgtm https://codereview.chromium.org/2845843002/diff/40001/recipe_engine/refs.py File recipe_engine/refs.py (right): https://codereview.chromium.org/2845843002/diff/40001/recipe_engine/refs.py#newcode24 recipe_engine/refs.py:24: modules = args.modules nit: in other CLs, you ...
3 years, 7 months ago (2017-04-27 16:40:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845843002/40001
3 years, 7 months ago (2017-04-29 07:20:23 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 07:23:17 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/bcf9286338730769356d98e274b71e1b641...

Powered by Google App Engine
This is Rietveld 408576698