Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2839353003: [recipes.py] move remote arg parsing to its module (Closed)

Created:
3 years, 8 months ago by iannucci
Modified:
3 years, 7 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : Also print stderr #

Patch Set 5 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -49 lines) Patch
M recipe_engine/remote.py View 1 chunk +33 lines, -1 line 0 comments Download
M recipes.py View 1 2 3 4 6 chunks +18 lines, -47 lines 2 comments Download
M unittests/remote_test.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 26 (21 generated)
iannucci
3 years, 8 months ago (2017-04-27 00:40:55 UTC) #1
dnj
lgtm w/ comment https://codereview.chromium.org/2839353003/diff/60002/recipes.py File recipes.py (right): https://codereview.chromium.org/2839353003/diff/60002/recipes.py#newcode350 recipes.py:350: bare_command=False, # don't call postprocess_func, don't ...
3 years, 7 months ago (2017-04-27 16:38:40 UTC) #20
iannucci
documented in a later cl :)
3 years, 7 months ago (2017-04-29 06:29:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839353003/60002
3 years, 7 months ago (2017-04-29 06:30:34 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 06:33:25 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:60002) as
https://github.com/luci/recipes-py/commit/0b1247f8506739b0c6d6adc1f8145cb4d0d...

Powered by Google App Engine
This is Rietveld 408576698