components/tracing/common/process_metrics_memory_dump_provider.cc - Issue 2845813005: memory-infra: Plumb platform_private_footprint to service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/common/process_metrics_memory_dump_provider.cc

Issue 2845813005: memory-infra: Plumb platform_private_footprint to service (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/common/process_metrics_memory_dump_provider.cc

diff --git a/components/tracing/common/process_metrics_memory_dump_provider.cc b/components/tracing/common/process_metrics_memory_dump_provider.cc

index 3f2abde07f9c7143049f87ab7065c24e39efa490..41a20a68472c21872f42122e6c8bb4e68cee443a 100644

--- a/components/tracing/common/process_metrics_memory_dump_provider.cc

+++ b/components/tracing/common/process_metrics_memory_dump_provider.cc

@@ -671,6 +671,7 @@ bool ProcessMetricsMemoryDumpProvider::DumpProcessTotals(

pmd->process_totals()->set_resident_set_bytes(rss_bytes);

pmd->set_has_process_totals();

pmd->process_totals()->set_peak_resident_set_bytes(peak_rss_bytes);

+ LOG(ERROR) << "! setting rss " << rss_bytes;

Primiano Tucci (use gerrit) 2017/04/28 15:32:26 LOG(ERROR) << "! I don't think you mean to land th

// Returns true even if other metrics failed, since rss is reported.

return true;

« no previous file with comments | « no previous file | services/resource_coordinator/public/cpp/memory/memory_instrumentation.typemap » ('j') | no next file with comments »