Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2845793002: [Merge to 3071] Add the UMA metric Memory.Gpu.PhysicalFootprint.MacOS (Closed)

Created:
3 years, 8 months ago by erikchen
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to 3071] Add the UMA metric Memory.Gpu.PhysicalFootprint.MacOS > This is a temporary metric added to debug Issue 713854. The existing metrics > don't measure OpenGL memory usage. BUG=713854 Review-Url: https://codereview.chromium.org/2832933003 Cr-Commit-Position: refs/heads/master@{#466405} (cherry picked from commit e6da7858a3ffa600b6937f965dca0d685283cd68) Review-Url: https://codereview.chromium.org/2845793002 . Cr-Commit-Position: refs/branch-heads/3071@{#240} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/cc50b61198ad671177ecc4d8fcab71310fd75739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -1 line) Patch
M base/process/process_metrics.h View 1 chunk +6 lines, -0 lines 0 comments Download
M base/process/process_metrics_mac.cc View 3 chunks +47 lines, -0 lines 0 comments Download
M chrome/browser/memory_details.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_memory_details.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
3 years, 8 months ago (2017-04-26 23:25:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc50b61198ad671177ecc4d8fcab71310fd75739.

Powered by Google App Engine
This is Rietveld 408576698