Add the UMA metric Memory.Gpu.PhysicalFootprint.MacOS

Add the UMA metric Memory.Gpu.PhysicalFootprint.MacOS

This is a temporary metric added to debug Issue 713854. The existing metrics
don't measure OpenGL memory usage.

BUG=713854
Review-Url: https://codereview.chromium.org/2832933003
Cr-Commit-Position: refs/heads/master@{#466405}
Committed: https://chromium.googlesource.com/chromium/src/+/e6da7858a3ffa600b6937f965dca0d685283cd68

[erikchen, 2017-04-21 01:06:16]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 01:06:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-04-21 01:08:43]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 01:09:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-04-21 02:17:56]

erikchen@chromium.org changed reviewers:
+ asvitkine@chromium.org, mark@chromium.org, thakis@chromium.org

[erikchen, 2017-04-21 02:17:57]

mark: Please review base/
thakis: Please review chrome/
asvitkine: Please review histograms.xml

[commit-bot: I haz the power, 2017-04-21 02:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 02:23:59]

Dry run: This issue passed the CQ dry run.

[Mark Mentovai, 2017-04-21 03:30:00]

base LGTM otherwise

https://codereview.chromium.org/2832933003/diff/20001/base/process/process_me...
File base/process/process_metrics_mac.cc (right):

https://codereview.chromium.org/2832933003/diff/20001/base/process/process_me...
base/process/process_metrics_mac.cc:28: MAC_OS_X_VERSION_MIN_REQUIRED <
MAC_OS_X_VERSION_10_11
Whether task_vm_info is available and correct is an SDK (MAX_ALLOWED) thing, not
a deployment target (MIN_REQUIRED) thing.

[Nico, 2017-04-21 14:29:26]

lgtm

[Alexei Svitkine (slow), 2017-04-21 15:03:33]

lgtm

[erikchen, 2017-04-21 17:35:32]

https://codereview.chromium.org/2832933003/diff/20001/base/process/process_me...
File base/process/process_metrics_mac.cc (right):

https://codereview.chromium.org/2832933003/diff/20001/base/process/process_me...
base/process/process_metrics_mac.cc:28: MAC_OS_X_VERSION_MIN_REQUIRED <
MAC_OS_X_VERSION_10_11
On 2017/04/21 03:30:00, Mark Mentovai wrote:
> Whether task_vm_info is available and correct is an SDK (MAX_ALLOWED) thing,
not
> a deployment target (MIN_REQUIRED) thing.

Thanks, I seem to have a penchant for mixing the two up.

[erikchen, 2017-04-21 17:35:37]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-04-21 17:35:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
thakis@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2832933003/#ps40001
(title: "Comments from mark.")

[commit-bot: I haz the power, 2017-04-21 17:35:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 19:07:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492796137008400,
"parent_rev": "56f812cccd421b2170268136da262c9d5a19acfd", "commit_rev":
"e6da7858a3ffa600b6937f965dca0d685283cd68"}

[commit-bot: I haz the power, 2017-04-21 19:07:09]

Description was changed from

==========
Add the UMA metric Memory.Gpu.PhysicalFootprint.MacOS

This is a temporary metric added to debug Issue 713854. The existing metrics
don't measure OpenGL memory usage.

BUG=713854
==========

to

==========
Add the UMA metric Memory.Gpu.PhysicalFootprint.MacOS

This is a temporary metric added to debug Issue 713854. The existing metrics
don't measure OpenGL memory usage.

BUG=713854

Review-Url: https://codereview.chromium.org/2832933003
Cr-Commit-Position: refs/heads/master@{#466405}
Committed:
https://chromium.googlesource.com/chromium/src/+/e6da7858a3ffa600b6937f965dca...
==========

[commit-bot: I haz the power, 2017-04-21 19:07:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e6da7858a3ffa600b6937f965dca...

[zino, 2017-04-23 20:35:44]

jinho.bang@samsung.com changed reviewers:
+ jinho.bang@samsung.com

[zino, 2017-04-23 20:35:45]

https://codereview.chromium.org/2832933003/diff/20001/base/process/process_me...
File base/process/process_metrics_mac.cc (right):

https://codereview.chromium.org/2832933003/diff/20001/base/process/process_me...
base/process/process_metrics_mac.cc:56: mach_msg_type_number_t
ChromeTaskVMInfoCount = TASK_VM_INFO_REV1_COUNT;
Hi

This line is breaking build on 11.x.
I'm not sure but the TASK_VM_INFO_REV1_COUNT is not defined in 11.x.
(https://github.com/practicalswift/osx/blob/c72157565335b24d683dc7316873513ec3...)

[erikchen, 2017-04-24 17:38:06]

On 2017/04/23 20:35:45, zino wrote:
>
https://codereview.chromium.org/2832933003/diff/20001/base/process/process_me...
> File base/process/process_metrics_mac.cc (right):
> 
>
https://codereview.chromium.org/2832933003/diff/20001/base/process/process_me...
> base/process/process_metrics_mac.cc:56: mach_msg_type_number_t
> ChromeTaskVMInfoCount = TASK_VM_INFO_REV1_COUNT;
> Hi
> 
> This line is breaking build on 11.x.
> I'm not sure but the TASK_VM_INFO_REV1_COUNT is not defined in 11.x.
>
(https://github.com/practicalswift/osx/blob/c72157565335b24d683dc7316873513ec3...)

CL with fix: https://codereview.chromium.org/2843463003/