Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 2845493002: [LayoutNG] Fix empty inlines to influence the used line height (Closed)

Created:
2 years, 6 months ago by kojii
Modified:
2 years, 6 months ago
Reviewers:
eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Fix empty inlines to influence the used line height This patch matches NGInlineLayoutAlgorithm to CSS2 10.8 Line height calculations: the 'line-height' and 'vertical-align' properties[1] defining empty inline elements should influence line height. Also, since the introduction of NGInlineBoxState, we had two places to compute the union of boxes; NGInlineBoxState.stack_[0] and NGLineBoxFragmentBuilder. Some code were uniting boxes to wrong one. This patch unifies them to NGInlineBoxState. [1] https://drafts.csswg.org/css2/visudet.html#line-height BUG=636993 Review-Url: https://codereview.chromium.org/2845493002 Cr-Commit-Position: refs/heads/master@{#467278} Committed: https://chromium.googlesource.com/chromium/src/+/c7a4e70db7ce16df575a5158a5ba9a383b88084c

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add spec link to the comment #

Patch Set 4 : Mark failure in a test in CSS2/normal-flow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -52 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.h View 1 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc View 1 3 chunks +37 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc View 1 2 2 chunks +17 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
kojii
PTAL.
2 years, 6 months ago (2017-04-26 06:02:31 UTC) #5
eae
OK, could you please add a comment explaining it and link to the spec? LGTM
2 years, 6 months ago (2017-04-26 06:05:02 UTC) #6
kojii
On 2017/04/26 at 06:05:02, eae wrote: > OK, could you please add a comment explaining ...
2 years, 6 months ago (2017-04-26 06:28:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845493002/40001
2 years, 6 months ago (2017-04-26 06:28:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845493002/60001
2 years, 6 months ago (2017-04-26 09:17:28 UTC) #21
commit-bot: I haz the power
2 years, 6 months ago (2017-04-26 09:22:29 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c7a4e70db7ce16df575a5158a5ba...

Powered by Google App Engine
This is Rietveld 408576698