[LayoutNG] Fix empty inlines to influence the used line height

[LayoutNG] Fix empty inlines to influence the used line height

This patch matches NGInlineLayoutAlgorithm to CSS2 10.8 Line height
calculations: the 'line-height' and 'vertical-align' properties[1]
defining empty inline elements should influence line height.

Also, since the introduction of NGInlineBoxState, we had two places to
compute the union of boxes; NGInlineBoxState.stack_[0] and
NGLineBoxFragmentBuilder. Some code were uniting boxes to wrong one.
This patch unifies them to NGInlineBoxState.

[1] https://drafts.csswg.org/css2/visudet.html#line-height

BUG=636993
Review-Url: https://codereview.chromium.org/2845493002
Cr-Commit-Position: refs/heads/master@{#467278}
Committed: https://chromium.googlesource.com/chromium/src/+/c7a4e70db7ce16df575a5158a5ba9a383b88084c

[kojii, 2017-04-26 05:54:36]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 05:54:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-04-26 06:00:46]

Description was changed from

==========
ngemptyinline

BUG=
==========

to

==========
[LayoutNG] Fix empty inlines to influence the used line height

This patch matches NGInlineLayoutAlgorithm to CSS2 10.8 Line height
calculations: the 'line-height' and 'vertical-align' properties[1]
defining empty inline elements should influence line height.

Also, since the introduction of NGInlineBoxState, we had two places to
compute the union of boxes; NGInlineBoxState.stack_[0] and
NGLineBoxFragmentBuilder. Some code were uniting boxes to wrong one.
This patch unifies them to NGInlineBoxState.

[1] https://drafts.csswg.org/css2/visudet.html#line-height

BUG=636993
==========

[kojii, 2017-04-26 06:02:30]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-04-26 06:02:31]

PTAL.

[eae, 2017-04-26 06:05:02]

OK, could you please add a comment explaining it and link to the spec?

LGTM

[kojii, 2017-04-26 06:14:47]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 06:14:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-04-26 06:28:27]

On 2017/04/26 at 06:05:02, eae wrote:
> OK, could you please add a comment explaining it and link to the spec?

Done, added the spec link.

[kojii, 2017-04-26 06:28:32]

The CQ bit was unchecked by kojii@chromium.org

[kojii, 2017-04-26 06:28:34]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-04-26 06:28:34]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2845493002/#ps40001
(title: "Add spec link to the comment")

[commit-bot: I haz the power, 2017-04-26 06:28:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-04-26 07:28:39]

The CQ bit was unchecked by kojii@chromium.org

[kojii, 2017-04-26 07:29:35]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 07:29:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 09:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 09:13:49]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-04-26 09:17:21]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-04-26 09:17:21]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2845493002/#ps60001
(title: "Mark failure in a test in CSS2/normal-flow")

[commit-bot: I haz the power, 2017-04-26 09:17:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 09:22:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493198241391850,
"parent_rev": "b58fb7956f56025d0cf384376995ad54f39b6c78", "commit_rev":
"c7a4e70db7ce16df575a5158a5ba9a383b88084c"}

[commit-bot: I haz the power, 2017-04-26 09:22:28]

Description was changed from

==========
[LayoutNG] Fix empty inlines to influence the used line height

This patch matches NGInlineLayoutAlgorithm to CSS2 10.8 Line height
calculations: the 'line-height' and 'vertical-align' properties[1]
defining empty inline elements should influence line height.

Also, since the introduction of NGInlineBoxState, we had two places to
compute the union of boxes; NGInlineBoxState.stack_[0] and
NGLineBoxFragmentBuilder. Some code were uniting boxes to wrong one.
This patch unifies them to NGInlineBoxState.

[1] https://drafts.csswg.org/css2/visudet.html#line-height

BUG=636993
==========

to

==========
[LayoutNG] Fix empty inlines to influence the used line height

This patch matches NGInlineLayoutAlgorithm to CSS2 10.8 Line height
calculations: the 'line-height' and 'vertical-align' properties[1]
defining empty inline elements should influence line height.

Also, since the introduction of NGInlineBoxState, we had two places to
compute the union of boxes; NGInlineBoxState.stack_[0] and
NGLineBoxFragmentBuilder. Some code were uniting boxes to wrong one.
This patch unifies them to NGInlineBoxState.

[1] https://drafts.csswg.org/css2/visudet.html#line-height

BUG=636993

Review-Url: https://codereview.chromium.org/2845493002
Cr-Commit-Position: refs/heads/master@{#467278}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7a4e70db7ce16df575a5158a5ba...
==========

[commit-bot: I haz the power, 2017-04-26 09:22:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c7a4e70db7ce16df575a5158a5ba...