third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h - Issue 2845493002: [LayoutNG] Fix empty inlines to influence the used line height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

Issue 2845493002: [LayoutNG] Fix empty inlines to influence the used line height (Closed)

Patch Set: Mark failure in a test in CSS2/normal-flow Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

index c1e0c89325c641b525dadf184b09b501aab12485..e7e16de1f46a6772a9efff5cbd1d4bb2dd12074b 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

@@ -20,7 +20,7 @@ class CORE_EXPORT NGLineBoxFragmentBuilder final {

STACK_ALLOCATED();

public:

- NGLineBoxFragmentBuilder(NGInlineNode*, const NGLineHeightMetrics&);

+ explicit NGLineBoxFragmentBuilder(NGInlineNode*);

NGLineBoxFragmentBuilder& SetDirection(TextDirection);

@@ -35,7 +35,7 @@ class CORE_EXPORT NGLineBoxFragmentBuilder final {

return children_;

}

- void UniteMetrics(const NGLineHeightMetrics&);

+ void SetMetrics(const NGLineHeightMetrics&);

const NGLineHeightMetrics& Metrics() const { return metrics_; }

// Set the break token for the fragment to build.