Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2845483002:
Add README with info on how to add iOS Password Managers. (Closed)
|
Created:
3 years, 8 months ago by pkl (ping after 24h if needed) Modified:
3 years, 7 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd README with info on how to add iOS Password Managers.
TBR=jif@chromium.org
Review-Url: https://codereview.chromium.org/2845483002
Cr-Commit-Position: refs/heads/master@{#468616}
Committed: https://chromium.googlesource.com/chromium/src/+/26f36626b38af4124e677b1b80d1e18d4885cce7
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
pkl@chromium.org changed reviewers: + jif@chromium.org
jif@google.com changed reviewers: + jif@google.com
lgtm
The CQ bit was checked by pkl@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/04/28 19:07:45, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. Hi, jif@. Please lg from your @chromium.org account.
Description was changed from ========== Add README with info on how to add iOS Password Managers. ========== to ========== Add README with info on how to add iOS Password Managers. TBR=jif@chromium.org ==========
The CQ bit was checked by pkl@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by jif@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493730819050630, "parent_rev":
"d680636742fdea611199070ab50d18a0e5f7c765", "commit_rev":
"26f36626b38af4124e677b1b80d1e18d4885cce7"}
Message was sent while issue was closed.
Description was changed from ========== Add README with info on how to add iOS Password Managers. TBR=jif@chromium.org ========== to ========== Add README with info on how to add iOS Password Managers. TBR=jif@chromium.org Review-Url: https://codereview.chromium.org/2845483002 Cr-Commit-Position: refs/heads/master@{#468616} Committed: https://chromium.googlesource.com/chromium/src/+/26f36626b38af4124e677b1b80d1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/26f36626b38af4124e677b1b80d1... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
