Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: ios/chrome/browser/ui/activity_services/README.md

Issue 2845483002: Add README with info on how to add iOS Password Managers. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # iOS Application Specific Services in Chrome for iOS
2
3 [UIActivity][1] is an abstract class for implementing app-specific services
4 such as Share (to social media), Print, Reading List, and Password Management
5 app extensions.
6
7 ## Adding iOS Password Managers App Extensions
8
9 Chrome for iOS recognizes an action extension is a Password Manager app
10 extension in one of the following two ways.
11
12 1. By Bundle ID match. If the bundle ID for the app extension contains
13 the substring `find-login-action`, it will be handled as a Password
14 Manager app extension.
15
16 1. By explicitly listing in [`activity_type_util.mm`][2]. The anonymous
17 namespace function `IsPasswordManagerActivity()` in this file contains
18 a static structure listing all the Password Manager app extensions
19 known to Chrome for iOS. The first field is a string containing either
20 the full bundle ID or the leading portion of the bundle ID. The second
21 field is a flag to indicate whether a full bundle ID is expected or
22 if the string is intended to be a prefix for matching bundle IDs.
23
24 The first option is recommended because it does not require any code
25 changes to Chrome. If an app extension meets the first condition, it
26 works with current and previous versions of Chrome for iOS (since early
27 2016). If for any reasons that an app extension cannot change its
28 bundle ID, option 2 may be used. To add support to Chrome for iOS, submit
29 a changelist similar to [this][3] for review.
30
31
32 [1]: https://developer.apple.com/reference/uikit/uiactivity?language=objc
33 [2]: ./activity_type_util.mm
34 [3]: https://codereview.chromium.org/2820113002/
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698