Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2845463003: Rename StyleInheritedData members. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename StyleInheritedData members. This patch renames: - ComputedStyle::style_inherited_data_ -> ComputedStyle::inherited_data_ (to be consistent with the other data refs like box_data_) - Members of StyleInheritedData to have trailing underscore. so that StyleInheritedData can be generated without name changes showing up in the diff. BUG=628043 Review-Url: https://codereview.chromium.org/2845463003 Cr-Commit-Position: refs/heads/master@{#467595} Committed: https://chromium.googlesource.com/chromium/src/+/a1db173fa4473293335929920dcb90c13f2390d4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -64 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 13 chunks +36 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleInheritedData.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleInheritedData.cpp View 1 chunk +18 lines, -18 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (20 generated)
shend
Hey Alan, PTAL
3 years, 8 months ago (2017-04-26 05:37:43 UTC) #8
rune
lgtm
3 years, 8 months ago (2017-04-26 08:54:27 UTC) #12
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-04-27 01:30:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845463003/40001
3 years, 7 months ago (2017-04-27 04:51:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845463003/40001
3 years, 7 months ago (2017-04-27 04:52:29 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 05:53:19 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a1db173fa4473293335929920dcb...

Powered by Google App Engine
This is Rietveld 408576698