Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2844613002: Remove unused includes of StyleInheritedData. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, haraken, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused includes of StyleInheritedData. Before we can generate StyleInheritedData, we must first remove any references to it outside of ComputedStyle. A lot of files include the header file for StyleInheritedData, but do not use it. This will cause a compile error when we remove the file to generate it instead. This patch removes the unused includes, as lead-up to generating StyleInheritedData. BUG=628043 Review-Url: https://codereview.chromium.org/2844613002 Cr-Commit-Position: refs/heads/master@{#467616} Committed: https://chromium.googlesource.com/chromium/src/+/2c6e211f16b282ce819a1c63e78ec2bfba7280f5

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 22 (13 generated)
shend
Hi Eddy, PTAL :)
3 years, 8 months ago (2017-04-26 05:32:19 UTC) #2
rune
lgtm
3 years, 8 months ago (2017-04-26 08:55:04 UTC) #4
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-27 03:13:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844613002/20001
3 years, 8 months ago (2017-04-27 05:56:26 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/421821)
3 years, 8 months ago (2017-04-27 06:07:20 UTC) #14
shend
Hi Haraken, can you PTAL for web/ ?
3 years, 8 months ago (2017-04-27 06:10:21 UTC) #16
haraken
LGTM
3 years, 8 months ago (2017-04-27 07:14:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844613002/20001
3 years, 8 months ago (2017-04-27 07:22:39 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 07:27:42 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c6e211f16b282ce819a1c63e78e...

Powered by Google App Engine
This is Rietveld 408576698