Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 2845383002: Remove SearchIPCRouter::Delegate::OnInstantSupportDetermined (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper.h
diff --git a/chrome/browser/ui/search/search_tab_helper.h b/chrome/browser/ui/search/search_tab_helper.h
index 83b1a4b50d258e71c6851ceb3bd90d2cbab8bd46..5b10a2ff672ad95c94ef9f58fb0d2e185b7379c6 100644
--- a/chrome/browser/ui/search/search_tab_helper.h
+++ b/chrome/browser/ui/search/search_tab_helper.h
@@ -38,10 +38,9 @@ class SearchIPCRouterTest;
// Per-tab search "helper". Acts as the owner and controller of the tab's
// search UI model.
//
-// When the page is finished loading, SearchTabHelper determines the instant
-// support for the page. When a navigation entry is committed (except for
-// in-page navigations), SearchTabHelper resets the instant support state to
-// INSTANT_SUPPORT_UNKNOWN and cause support to be determined again.
+// When a navigation is committed and when the page is finished loading,
+// SearchTabHelper determines the instant support for the page, i.e. whether
+// the page is rendered in the instant process.
class SearchTabHelper : public content::WebContentsObserver,
public content::WebContentsUserData<SearchTabHelper>,
public InstantServiceObserver,
@@ -134,7 +133,6 @@ class SearchTabHelper : public content::WebContentsObserver,
const content::LoadCommittedDetails& load_details) override;
// Overridden from SearchIPCRouter::Delegate:
- void OnInstantSupportDetermined(bool supports_instant) override;
void FocusOmnibox(OmniboxFocusState state) override;
void OnDeleteMostVisitedItem(const GURL& url) override;
void OnUndoMostVisitedDeletion(const GURL& url) override;
« no previous file with comments | « chrome/browser/ui/search/search_ipc_router_unittest.cc ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698