Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2845303002: Remove InstantTab::Delegate::InstantSupportDetermined (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove InstantTab::Delegate::InstantSupportDetermined This is the first of a series of CLs to get rid of the notion of "Instant support" entirely, see https://bugs.chromium.org/p/chromium/issues/detail?id=627747#c41 BUG=627747 Review-Url: https://codereview.chromium.org/2845303002 Cr-Commit-Position: refs/heads/master@{#467974} Committed: https://chromium.googlesource.com/chromium/src/+/f2ffcffa94cdf2848a2219cc4931757fcaedd827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -77 lines) Patch
M chrome/browser/ui/search/instant_controller.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 2 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/ui/search/instant_tab.h View 4 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/ui/search/instant_tab.cc View 4 chunks +1 line, -38 lines 0 comments Download
M chrome/browser/ui/search/instant_tab_unittest.cc View 4 chunks +0 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Marc Treib
I decided to spend some time deleting old cruft again ;) PTAL!
3 years, 7 months ago (2017-04-28 12:46:28 UTC) #5
sfiera
LGTM
3 years, 7 months ago (2017-04-28 12:52:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845303002/1
3 years, 7 months ago (2017-04-28 12:58:59 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 13:20:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2ffcffa94cdf2848a2219cc4931...

Powered by Google App Engine
This is Rietveld 408576698