Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/ui/search/instant_tab_unittest.cc

Issue 2845303002: Remove InstantTab::Delegate::InstantSupportDetermined (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/search/instant_tab.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_tab_unittest.cc
diff --git a/chrome/browser/ui/search/instant_tab_unittest.cc b/chrome/browser/ui/search/instant_tab_unittest.cc
index 8991f260de3f0b39483a2fd51553b6e5e254d3ea..39914f43849399d6be3d643937793328fdc46adf 100644
--- a/chrome/browser/ui/search/instant_tab_unittest.cc
+++ b/chrome/browser/ui/search/instant_tab_unittest.cc
@@ -36,9 +36,6 @@ class FakePageDelegate : public InstantTab::Delegate {
virtual ~FakePageDelegate() {
}
- MOCK_METHOD2(InstantSupportDetermined,
- void(const content::WebContents* contents,
- bool supports_instant));
MOCK_METHOD2(InstantTabAboutToNavigateMainFrame,
void(const content::WebContents* contents, const GURL& url));
};
@@ -83,7 +80,6 @@ TEST_F(InstantTabTest, DetermineIfPageSupportsInstant_Local) {
EXPECT_FALSE(SupportsInstant());
page->Init();
NavigateAndCommit(GURL(chrome::kChromeSearchLocalNtpUrl));
- EXPECT_CALL(delegate, InstantSupportDetermined(web_contents(), true));
search_tab()->DetermineIfPageSupportsInstant();
EXPECT_TRUE(SupportsInstant());
}
@@ -107,7 +103,6 @@ TEST_F(InstantTabTest, PageURLDoesntBelongToInstantRenderer) {
// SearchTabHelper::DeterminerIfPageSupportsInstant() should return
// immediately without dispatching any message to the renderer.
NavigateAndCommit(GURL("http://www.example.com"));
- EXPECT_CALL(delegate, InstantSupportDetermined(web_contents(), false));
EXPECT_CALL(mock_search_box, DetermineIfPageSupportsInstant()).Times(0);
search_tab()->DetermineIfPageSupportsInstant();
@@ -124,8 +119,6 @@ TEST_F(InstantTabTest, PageSupportsInstant) {
EXPECT_CALL(mock_search_box, DetermineIfPageSupportsInstant());
search_tab()->DetermineIfPageSupportsInstant();
- EXPECT_CALL(delegate, InstantSupportDetermined(web_contents(), true));
-
// Assume the page supports instant. Invoke the message reply handler to make
// sure the InstantTab is notified about the instant support state.
const content::NavigationEntry* entry =
« no previous file with comments | « chrome/browser/ui/search/instant_tab.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698