Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2845243002: Moving BindingManager and ChildProcessConnection to base/.

Created:
3 years, 7 months ago by Jay Civelli
Modified:
3 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vmpstr+watch_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, agrieve+watch_chromium.org, danakj+watch_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving BindingManager and ChildProcessConnection to base/. Removed the last dependencies to content/ for BindingManager and the various ChildProcessConnection classes and moved them to base/. Most notably: - changed the use of LauncherThread to a thread specified on creation of BaseChildProcessConnection and BindingManagerImpl . - added a new method to BaseChildProcessConnection.ConnectionCallback that lets clients specify extra parameters that should be passed to the created service. BUG=702316

Patch Set 1 : Moving BindingManager and ChildProcessConnection to base/. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -2221 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M base/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
A + base/android/java/src/org/chromium/base/process_launcher/BaseChildProcessConnection.java View 19 chunks +66 lines, -44 lines 2 comments Download
A + base/android/java/src/org/chromium/base/process_launcher/BindingManager.java View 1 chunk +1 line, -1 line 0 comments Download
A + base/android/java/src/org/chromium/base/process_launcher/BindingManagerImpl.java View 16 chunks +40 lines, -28 lines 0 comments Download
A base/android/java/src/org/chromium/base/process_launcher/ChildProcessConstants.java View 1 chunk +19 lines, -0 lines 0 comments Download
A + base/android/java/src/org/chromium/base/process_launcher/ImportantChildProcessConnection.java View 2 chunks +9 lines, -10 lines 0 comments Download
A + base/android/java/src/org/chromium/base/process_launcher/ManagedChildProcessConnection.java View 10 chunks +24 lines, -23 lines 0 comments Download
A + base/android/junit/src/org/chromium/base/process_launcher/BindingManagerImplTest.java View 9 chunks +18 lines, -26 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 3 chunks +1 line, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java View 3 chunks +7 lines, -6 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/BaseChildProcessConnection.java View 1 chunk +0 lines, -519 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/BindingManager.java View 1 chunk +0 lines, -89 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java View 1 chunk +0 lines, -465 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java View 2 chunks +6 lines, -3 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java View 1 chunk +0 lines, -37 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 5 chunks +20 lines, -21 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java View 1 chunk +3 lines, -0 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/browser/ContentChildProcessConstants.java View 2 chunks +1 line, -8 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ImportantChildProcessConnection.java View 1 chunk +0 lines, -50 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/LauncherThread.java View 1 chunk +4 lines, -0 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ManagedChildProcessConnection.java View 1 chunk +0 lines, -197 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java View 1 chunk +1 line, -0 lines 0 comments Download
D content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java View 1 chunk +0 lines, -681 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestUtils.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Jay Civelli
3 years, 7 months ago (2017-04-28 07:21:40 UTC) #11
boliu
so I think Connection and Service should move at the same time? they really form ...
3 years, 7 months ago (2017-04-28 17:07:46 UTC) #15
Jay Civelli
On 2017/04/28 17:07:46, boliu wrote: > so I think Connection and Service should move at ...
3 years, 7 months ago (2017-04-28 17:12:31 UTC) #16
boliu
On 2017/04/28 17:12:31, Jay Civelli wrote: > On 2017/04/28 17:07:46, boliu wrote: > > so ...
3 years, 7 months ago (2017-04-28 17:16:12 UTC) #17
boliu
3 years, 7 months ago (2017-04-28 17:16:27 UTC) #18
and comment on base/ part

https://codereview.chromium.org/2845243002/diff/40001/base/android/java/src/o...
File
base/android/java/src/org/chromium/base/process_launcher/BaseChildProcessConnection.java
(right):

https://codereview.chromium.org/2845243002/diff/40001/base/android/java/src/o...
base/android/java/src/org/chromium/base/process_launcher/BaseChildProcessConnection.java:298:
checkOnValidThread();
no need to repeat this :p

https://codereview.chromium.org/2845243002/diff/40001/base/android/java/src/o...
base/android/java/src/org/chromium/base/process_launcher/BaseChildProcessConnection.java:457:
if (mConnectionCallback != null) {
is this check needed? should this be an assert instead?

Powered by Google App Engine
This is Rietveld 408576698