content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java - Issue 2845243002: Moving BindingManager and ChildProcessConnection to base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

Issue 2845243002: Moving BindingManager and ChildProcessConnection to base/.

Patch Set: Moving BindingManager and ChildProcessConnection to base/. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/java/src/org/chromium/base/process_launcher/BaseChildProcessConnection.java ('K') | « content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java ('k') | content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java b/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

index 7e3e9db222d281aa43e2b9ac7679af1990edf1db..d676c11d1823d8053861fbb2bb648b982caf0a4c 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

@@ -14,6 +14,9 @@ import android.text.TextUtils;

import org.chromium.base.Log;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.SuppressFBWarnings;

+import org.chromium.base.process_launcher.BaseChildProcessConnection;

+import org.chromium.base.process_launcher.ImportantChildProcessConnection;

+import org.chromium.base.process_launcher.ManagedChildProcessConnection;

import org.chromium.content.app.PrivilegedProcessService;

import org.chromium.content.app.SandboxedProcessService;

@@ -191,9 +194,9 @@ public class ChildConnectionAllocator {

}

int slot = mFreeConnectionIndices.remove(0);

assert mChildProcessConnections[slot] == null;

- mChildProcessConnections[slot] = mConnectionFactory.create(spawnData.getContext(), slot,

- mInSandbox, deathCallback, mChildClassName, childProcessCommonParameters,

- spawnData.getCreationParams());

+ mChildProcessConnections[slot] = mConnectionFactory.create(LauncherThread.getHandler(),

+ spawnData.getContext(), slot, mInSandbox, deathCallback, mChildClassName,

+ childProcessCommonParameters, spawnData.getCreationParams());

Log.d(TAG, "Allocator allocated a connection, sandbox: %b, slot: %d", mInSandbox, slot);

return mChildProcessConnections[slot];

}