Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2845233002: Generate getters/setters for border-spacing. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
nainar, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate getters/setters for border-spacing. Currently, the border-spacing properties: border-horizontal-spacing and border-vertical-spacing are 'storage_only' fields, so they don't have generated public getters/setters. This patch changes them to 'primitive' so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/7f153ab5b642e1a9dd7fb9e0573adaa9/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2845233002 Cr-Commit-Position: refs/heads/master@{#472602} Committed: https://chromium.googlesource.com/chromium/src/+/01d27a05ed3a1e5c29015632e463eb938306adbe

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 24 (19 generated)
shend
Hi Naina, PTAL
3 years, 7 months ago (2017-05-08 06:03:43 UTC) #3
nainar
lgtm
3 years, 7 months ago (2017-05-08 06:06:23 UTC) #4
rune
rs lgtm
3 years, 7 months ago (2017-05-08 07:40:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845233002/40001
3 years, 7 months ago (2017-05-17 23:33:55 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 23:44:02 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/01d27a05ed3a1e5c29015632e463...

Powered by Google App Engine
This is Rietveld 408576698