Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2845163006: Android: Add version suffix to extracted .pak files (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Android: Add version suffix to extracted .pak files This will (hopefully) guarantee that we never use a stale .pak file, and actually simplifies the triggering & clean-up logic somewhat (e.g. no longer uses SharedPreferences). BUG=691719 Review-Url: https://codereview.chromium.org/2828823002 Cr-Commit-Position: refs/heads/master@{#466067} (cherry picked from commit a9cdba46ce4367c96aa7c9a0655295a5b8de5992) Review-Url: https://codereview.chromium.org/2845163006 . Cr-Commit-Position: refs/branch-heads/3071@{#294} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/0009f4a2703ca2b72878f68865714c9c1ea2e677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -110 lines) Patch
M base/android/build_info.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/android/build_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/BuildInfo.java View 1 chunk +16 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 6 chunks +45 lines, -108 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
agrieve
3 years, 7 months ago (2017-04-28 15:31:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0009f4a2703ca2b72878f68865714c9c1ea2e677.

Powered by Google App Engine
This is Rietveld 408576698