Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2828823002: Android: Add version suffix to extracted .pak files (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson, sadrul
CC:
chromium-reviews, danakj+watch_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Add version suffix to extracted .pak files This will (hopefully) guarantee that we never use a stale .pak file, and actually simplifies the triggering & clean-up logic somewhat (e.g. no longer uses SharedPreferences). BUG=691719 Review-Url: https://codereview.chromium.org/2828823002 Cr-Commit-Position: refs/heads/master@{#466067} Committed: https://chromium.googlesource.com/chromium/src/+/a9cdba46ce4367c96aa7c9a0655295a5b8de5992

Patch Set 1 #

Total comments: 2

Patch Set 2 : combine try stmts, fix tests (hopefully) #

Patch Set 3 : fix typo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -110 lines) Patch
M base/android/build_info.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/android/build_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/BuildInfo.java View 1 chunk +16 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 1 6 chunks +45 lines, -108 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 2 3 chunks +17 lines, -2 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 25 (17 generated)
agrieve
estevenson - Please review the change. sadrul - Please review change to ui/
3 years, 8 months ago (2017-04-19 18:06:21 UTC) #2
estevenson
lgtm, this approach seems much less error prone to me! https://codereview.chromium.org/2828823002/diff/1/base/android/java/src/org/chromium/base/ResourceExtractor.java File base/android/java/src/org/chromium/base/ResourceExtractor.java (right): https://codereview.chromium.org/2828823002/diff/1/base/android/java/src/org/chromium/base/ResourceExtractor.java#newcode97 ...
3 years, 8 months ago (2017-04-19 19:04:48 UTC) #5
sadrul
The failures in the android trybots look relevant. Mind taking a look at those?
3 years, 8 months ago (2017-04-19 21:51:38 UTC) #8
agrieve
Fixed the failures. https://codereview.chromium.org/2828823002/diff/1/base/android/java/src/org/chromium/base/ResourceExtractor.java File base/android/java/src/org/chromium/base/ResourceExtractor.java (right): https://codereview.chromium.org/2828823002/diff/1/base/android/java/src/org/chromium/base/ResourceExtractor.java#newcode97 base/android/java/src/org/chromium/base/ResourceExtractor.java:97: throw new RuntimeException(e); On 2017/04/19 19:04:48, ...
3 years, 8 months ago (2017-04-20 04:00:06 UTC) #17
agrieve
https://codereview.chromium.org/2828823002/diff/40001/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): https://codereview.chromium.org/2828823002/diff/40001/ui/base/resource/resource_bundle.cc#newcode309 ui/base/resource/resource_bundle.cc:309: if (locale_file_path.value().find("chromium_tests") == std::string::npos) { Note: Although ugly, it's ...
3 years, 8 months ago (2017-04-20 15:54:38 UTC) #18
sadrul
lgtm
3 years, 8 months ago (2017-04-20 16:02:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828823002/40001
3 years, 8 months ago (2017-04-20 17:57:23 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 18:03:47 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a9cdba46ce4367c96aa7c9a06552...

Powered by Google App Engine
This is Rietveld 408576698