Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2845133002: Add friendly error message when GenTests is missing or misspelled (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add friendly error message when GenTests is missing or misspelled BUG=chromium:715372

Patch Set 1 #

Total comments: 2

Patch Set 2 : RunSteps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M recipe_engine/test.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M unittests/test_test.py View 1 2 chunks +31 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-04-27 14:34:56 UTC) #6
iannucci
lgtm https://codereview.chromium.org/2845133002/diff/1/recipe_engine/test.py File recipe_engine/test.py (right): https://codereview.chromium.org/2845133002/diff/1/recipe_engine/test.py#newcode401 recipe_engine/test.py:401: raise Exception('Missing or misspelled GenTests function.') Can you ...
3 years, 7 months ago (2017-04-27 19:28:34 UTC) #7
Paweł Hajdan Jr.
https://codereview.chromium.org/2845133002/diff/1/recipe_engine/test.py File recipe_engine/test.py (right): https://codereview.chromium.org/2845133002/diff/1/recipe_engine/test.py#newcode401 recipe_engine/test.py:401: raise Exception('Missing or misspelled GenTests function.') On 2017/04/27 19:28:33, ...
3 years, 7 months ago (2017-05-08 18:03:51 UTC) #10
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-08 18:07:37 UTC) #13

Powered by Google App Engine
This is Rietveld 408576698