Add friendly error message when GenTests is missing or misspelled

recipe_engine/test.py

 # Copyright 2017 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 from __future__ import print_function
 
 import argparse
 import bdb
 import cStringIO
 import contextlib
@@ skipping 379 matching lines @@
         # Run recipe loading under coverage context. This ensures we collect
         # coverage of all definitions and globals.
         recipe = _UNIVERSE_VIEW.load_recipe(recipe_name)
         test_api = loader.create_test_api(recipe.LOADED_DEPS, _UNIVERSE_VIEW)
 
         root, name = os.path.split(recipe_path)
         name = os.path.splitext(name)[0]
         # TODO(phajdan.jr): move expectation tree outside of the recipe tree.
         expect_dir = os.path.join(root, '%s.expected' % name)
 
+        if not recipe.gen_tests:
+          raise Exception('Missing or misspelled GenTests function.')

[iannucci, 2017/04/27 19:28:33]

Can you do the same for RunSteps too?

[Paweł Hajdan Jr., 2017/05/08 18:03:51]

Done.

Turns out it already works, just added a test for it.

+
         # Immediately convert to list to force running the generator under
         # coverage context. Otherwise coverage would only report executing
         # the function definition, not GenTests body.
         recipe_tests = list(recipe.gen_tests(test_api))
       coverage_data.update(cov.get_data())
 
       for test_data in recipe_tests:
         # Put the test data in shared cache. This way it can only be generated
         # once. We do this primarily for _correctness_ , for example in case
         # a weird recipe generates tests non-deterministically. The recipe
@@ skipping 493 matching lines @@
   Returns:
     Exit code
   """
   global _UNIVERSE_VIEW
   _UNIVERSE_VIEW = universe_view
   global _ENGINE_FLAGS
   _ENGINE_FLAGS = engine_flags
 
   args = parse_args(raw_args)
   return args.func(args)