Minor loader improvements.

Minor loader improvements.

This allows recipe_modules to do:
  from recipe_engine.recipe_api import RecipeApi

  class MyApi(RecipeApi):
    ...

Without explosion.

This will also raise a useful exception if a recipe script is missing GenTests
and/or RunSteps.

R=dnj@chromium.org, martiniss@chromium.org, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2864803003
Committed: https://github.com/luci/recipes-py/commit/5cdf9803d55420f3ae8d2e0dd524bc2de9c7284b

[dnj, 2017-05-06 02:37:14]

lgtm w/ comment

https://codereview.chromium.org/2864803003/diff/20001/recipe_engine/loader.py
File recipe_engine/loader.py (right):

https://codereview.chromium.org/2864803003/diff/20001/recipe_engine/loader.py...
recipe_engine/loader.py:110: raise Exception('Missing or misspelled RunSteps
function.')
Let's make this "MalformedRecipeError" or something - looks better to users, and
this will be presented to users.

[iannucci, 2017-05-06 02:53:18]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-05-06 02:53:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/2864803003/#ps40001
(title: "fix tests")

[commit-bot: I haz the power, 2017-05-06 02:53:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-05-06 02:54:55]

https://codereview.chromium.org/2864803003/diff/20001/recipe_engine/loader.py
File recipe_engine/loader.py (right):

https://codereview.chromium.org/2864803003/diff/20001/recipe_engine/loader.py...
recipe_engine/loader.py:110: raise Exception('Missing or misspelled RunSteps
function.')
On 2017/05/06 02:37:14, dnj wrote:
> Let's make this "MalformedRecipeError" or something - looks better to users,
and
> this will be presented to users.

Done, added test too :)

[commit-bot: I haz the power, 2017-05-06 02:56:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494039198186650,
"parent_rev": "2dc658ad29ce38a0364540d85d05dc3a2ab87f16", "commit_rev":
"5cdf9803d55420f3ae8d2e0dd524bc2de9c7284b"}

[commit-bot: I haz the power, 2017-05-06 02:56:36]

Description was changed from

==========
Minor loader improvements.

This allows recipe_modules to do:
  from recipe_engine.recipe_api import RecipeApi

  class MyApi(RecipeApi):
    ...

Without explosion.

This will also raise a useful exception if a recipe script is missing GenTests
and/or RunSteps.

R=dnj@chromium.org, martiniss@chromium.org, phajdan.jr@chromium.org
BUG=
==========

to

==========
Minor loader improvements.

This allows recipe_modules to do:
  from recipe_engine.recipe_api import RecipeApi

  class MyApi(RecipeApi):
    ...

Without explosion.

This will also raise a useful exception if a recipe script is missing GenTests
and/or RunSteps.

R=dnj@chromium.org, martiniss@chromium.org, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2864803003
Committed:
https://github.com/luci/recipes-py/commit/5cdf9803d55420f3ae8d2e0dd524bc2de9c...
==========

[commit-bot: I haz the power, 2017-05-06 02:56:37]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/5cdf9803d55420f3ae8d2e0dd524bc2de9c...