Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2845023003: Remove VR mode preventing CTA from destroying incognito profile. (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove VR mode preventing CTA from destroying incognito profile. VR no longer uses an HTML UI, so no longer uses the incognito profile. BUG= Review-Url: https://codereview.chromium.org/2845023003 Cr-Commit-Position: refs/heads/master@{#467975} Committed: https://chromium.googlesource.com/chromium/src/+/ea3be6229af5c379a95b66a07820abcee09ec940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL
3 years, 7 months ago (2017-04-27 22:29:49 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-04-28 07:26:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845023003/1
3 years, 7 months ago (2017-04-28 12:41:39 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 13:23:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea3be6229af5c379a95b66a07820...

Powered by Google App Engine
This is Rietveld 408576698