Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2813)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2845023003: Remove VR mode preventing CTA from destroying incognito profile. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 823b51b51e3e142e878a29a04c5b9a155db55564..da930f997c2aac9fb2f63e066990ae01bee1d5a4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -453,7 +453,6 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
@SuppressLint("NewApi")
private boolean shouldDestroyIncognitoProfile() {
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) return false;
- if (VrShellDelegate.isInVr()) return false; // VR uses an incognito profile for rendering.
Context context = ContextUtils.getApplicationContext();
ActivityManager manager =
@@ -1985,12 +1984,6 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
public void onExitVr() {
super.onExitVr();
mControlContainer.setVisibility(View.VISIBLE);
-
- // We prevent the incognito profile from being destroyed while in VR, so upon exiting VR we
- // should destroy it if necessary.
- if (shouldDestroyIncognitoProfile()) {
- Profile.getLastUsedProfile().getOffTheRecordProfile().destroyWhenAppropriate();
- }
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698