[Home] Remove BottomSheetObservers that are no longer used

[Home] Remove BottomSheetObservers that are no longer used

Previously, all observers of the bottom sheet had a life cycle that
matched the bottom sheet, so it wasn't necessary to remove the. The
suggestions content, however, does have the potential to be destroyed.
This change adds a removeObserver(...) method to the bottom sheet to
handle this case.

BUG=715979
Review-Url: https://codereview.chromium.org/2844993003
Cr-Commit-Position: refs/heads/master@{#468043}
Committed: https://chromium.googlesource.com/chromium/src/+/305e5224d9e9b11a609e17ca11866be3a3622ad6

[mdjones, 2017-04-27 17:18:47]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2017-04-27 17:18:48]

ptal

[dgn, 2017-04-27 22:11:31]

dgn@chromium.org changed reviewers:
+ dgn@chromium.org

[dgn, 2017-04-27 22:11:31]

Hum when I filed the bug I thought there was at least an observer on one of the
other sheet contents but I can't find it anymore...

Anyway, suggestions lgtm, Thanks!

[Theresa, 2017-04-28 00:44:50]

lgtm

[mdjones, 2017-04-28 15:37:53]

mdjones@chromium.org changed reviewers:
+ bauerb@chromium.org

[mdjones, 2017-04-28 15:37:53]

+bauerb for owners

[mdjones, 2017-04-28 15:41:48]

On 2017/04/28 15:37:53, mdjones wrote:
> +bauerb for owners

dgn@ is an owner, removing bauerb@

[mdjones, 2017-04-28 15:41:59]

Description was changed from

==========
[Home] Remove BottomSheetObservers that are no longer used

Previously, all observers of the bottom sheet had a life cycle that
matched the bottom sheet, so it wasn't necessary to remove the. The
suggestions content, however, does have the potential to be destroyed.
This change adds a removeObserver(...) method to the bottom sheet to
handle this case.

BUG=715979
==========

to

==========
[Home] Remove BottomSheetObservers that are no longer used

Previously, all observers of the bottom sheet had a life cycle that
matched the bottom sheet, so it wasn't necessary to remove the. The
suggestions content, however, does have the potential to be destroyed.
This change adds a removeObserver(...) method to the bottom sheet to
handle this case.

BUG=715979
==========

[mdjones, 2017-04-28 15:41:59]

mdjones@chromium.org changed reviewers:
- bauerb@chromium.org

[mdjones, 2017-04-28 15:42:05]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:42:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 17:27:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493394125614680, "parent_rev":
"d5c1d561e18cf1a7cecb015c17597fbff1619252", "commit_rev":
"305e5224d9e9b11a609e17ca11866be3a3622ad6"}

[commit-bot: I haz the power, 2017-04-28 17:27:28]

Description was changed from

==========
[Home] Remove BottomSheetObservers that are no longer used

Previously, all observers of the bottom sheet had a life cycle that
matched the bottom sheet, so it wasn't necessary to remove the. The
suggestions content, however, does have the potential to be destroyed.
This change adds a removeObserver(...) method to the bottom sheet to
handle this case.

BUG=715979
==========

to

==========
[Home] Remove BottomSheetObservers that are no longer used

Previously, all observers of the bottom sheet had a life cycle that
matched the bottom sheet, so it wasn't necessary to remove the. The
suggestions content, however, does have the potential to be destroyed.
This change adds a removeObserver(...) method to the bottom sheet to
handle this case.

BUG=715979

Review-Url: https://codereview.chromium.org/2844993003
Cr-Commit-Position: refs/heads/master@{#468043}
Committed:
https://chromium.googlesource.com/chromium/src/+/305e5224d9e9b11a609e17ca1186...
==========

[commit-bot: I haz the power, 2017-04-28 17:27:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/305e5224d9e9b11a609e17ca1186...