Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2844923002: Replace InterfaceRegistry on RenderFrameHostImpl with BinderRegistry (Closed)

Created:
3 years, 7 months ago by Ben Goodger (Google)
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, extensions-reviews_chromium.org, ios-reviews_chromium.org, ios-reviews+chrome_chromium.org, jam, marq+watch_chromium.org, nasko+codewatch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), qsr+mojo_chromium.org, sdefresne+watch_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace InterfaceRegistry on RenderFrameHostImpl with BinderRegistry R=rockot@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2844923002 Cr-Commit-Position: refs/heads/master@{#467888} Committed: https://chromium.googlesource.com/chromium/src/+/03ac5d0178c2f860ebc7b7105f1eaffc41722017

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -59 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/renderer_host/aw_render_view_host_ext.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_manager.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_mojo_service_registration.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_browsertest_base.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/mojo_web_ui_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/browser/distillability_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/file_system_app.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 chunks +6 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_manager/child_connection.h View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/service_manager/child_connection.cc View 1 2 3 4 5 6 1 chunk +2 lines, -5 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/render_frame_host.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -1 line 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/mojo/service_registration.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/mojo_web_ui_ios_controller.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 45 (41 generated)
Ben Goodger (Google)
3 years, 7 months ago (2017-04-27 19:33:57 UTC) #30
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-04-27 19:41:16 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844923002/240001
3 years, 7 months ago (2017-04-28 05:04:09 UTC) #42
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 05:14:38 UTC) #45
Message was sent while issue was closed.
Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/03ac5d0178c2f860ebc7b7105f1e...

Powered by Google App Engine
This is Rietveld 408576698