Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2844063003: Migrate RenderFrameImpl to use BinderRegistry. (Closed)

Created:
3 years, 8 months ago by Ben Goodger (Google)
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, blink-worker-reviews_chromium.org, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, donnd+watch_chromium.org, einbinder+watch-test-runner_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, gcasto+watchlist_chromium.org, horo+watch_chromium.org, jam, jochen+watch_chromium.org, jsbell+serviceworker_chromium.org, kalyank, kinuko+serviceworker, kinuko+watch, mathp+autofillwatch_chromium.org, michaeln, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nhiroki, Peter Beverloo, qsr+mojo_chromium.org, rjkroege, rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sadrul, sebsg+autofillwatch_chromium.org, serviceworker-reviews, shimazu+serviceworker_chromium.org, twellington+watch_chromium.org, tzik, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate RenderFrameImpl to use BinderRegistry. Also removes some extraneous interface_registry.h #includes. R=rockot@chromium.org Review-Url: https://codereview.chromium.org/2844063003 Cr-Commit-Position: refs/heads/master@{#467776} Committed: https://chromium.googlesource.com/chromium/src/+/803dba30b6180abc7f672ac834ed09b6323f27f8

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -58 lines) Patch
M chrome/renderer/chrome_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/contextual_search/renderer/overlay_js_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/utility_process_host_impl_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/websockets/websocket_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/service_manager/child_connection.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/renderer/render_frame.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/mojo/blink_interface_registry_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/mojo/blink_interface_registry_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 4 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 5 chunks +8 lines, -9 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M extensions/renderer/extensions_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser/browser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mash/catalog_viewer/catalog_viewer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/views_examples/views_examples.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mash/quick_launch/quick_launch.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mash/webtest/webtest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/device/device_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/navigation/navigation.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/public/cpp/binder_registry.h View 3 chunks +5 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/lib/binder_registry.cc View 2 chunks +5 lines, -1 line 0 comments Download
M services/service_manager/service_manager.cc View 1 2 2 chunks +44 lines, -1 line 1 comment Download
M services/ui/service.cc View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (15 generated)
Ben Goodger (Google)
3 years, 8 months ago (2017-04-26 23:57:49 UTC) #3
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/2844063003/diff/40001/services/service_manager/service_manager.cc File services/service_manager/service_manager.cc (right): https://codereview.chromium.org/2844063003/diff/40001/services/service_manager/service_manager.cc#newcode77 services/service_manager/service_manager.cc:77: InterfaceSet GetInterfacesToExpose(const InterfaceProviderSpec& source_spec, nit: Remove this from ...
3 years, 7 months ago (2017-04-27 19:30:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844063003/40001
3 years, 7 months ago (2017-04-27 19:35:19 UTC) #16
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-04-27 19:41:05 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:42:58 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/803dba30b6180abc7f672ac834ed...

Powered by Google App Engine
This is Rietveld 408576698