Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2844873002: Revert of Support tracing metrics for measureTime & measureFrameTime method in blink_perf (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
haraken, nednguyen, pdr., Xianzhu
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support tracing metrics for measureTime & measureFrameTime method in blink_perf (patchset #7 id:270001 of https://codereview.chromium.org/2819343002/ ) Reason for revert: Seems to broke telemetry tests https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/39895 Original issue's description: > Support tracing metrics for measureTime & measureFrameTime methods in blink_perf > > This CL adds support for tracing metrics with measureTime & > measureFrameTime methods in blink_perf harness. > > If a test has "tracingCategories" & "traceEventsToMeasure" fields > specified, Telemetry will enable the specified tracing categories & > compute the cpu time of all the specified trace events (one per test > run). > > Detailed examples of how to use this new API are in third_party/WebKit/PerformanceTests/TestData/ > > > BUG=701059 > > > Reviewer: you can see this in action by patching this CL & run: > ./tools/perf/run_benchmark --browser=system blink_perf.testing --story-filter=frame --output-format=json > [ RUN ] append-child-measure-time.html > ... > ... > CPU times of trace event "UpdateLayoutTree": > values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000, 2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms > avg 2.0804000000 ms > > CPU times of trace event "FrameView::layout": > values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000, 5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms > avg 5.1440000000 ms > [ RUN ] color-changes-measure-frame-time.html > ... > ... > CPU times of trace event "FrameView::prePaint": > values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000, 6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms > avg 6.3357777778 ms > > CPU times of trace event "FrameView::paintTree": > values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000, 30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms > avg 30.4702222222 ms > > After running the command above, the command also produces 2 trace files > locally, one for each test. > > Review-Url: https://codereview.chromium.org/2819343002 > Cr-Commit-Position: refs/heads/master@{#467445} > Committed: https://chromium.googlesource.com/chromium/src/+/0d2d43615b4553f00ac711f54dbcc0835f04366b TBR=pdr@chromium.org,haraken@chromium.org,wangxianzhu@chromium.org,nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=701059 Review-Url: https://codereview.chromium.org/2844873002 Cr-Commit-Position: refs/heads/master@{#467498} Committed: https://chromium.googlesource.com/chromium/src/+/c4abf7fbfae66c20c30fdce1c95827e687cd4976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -439 lines) Patch
D third_party/WebKit/PerformanceTests/TestData/append-child-measure-time.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html View 1 chunk +0 lines, -84 lines 0 comments Download
M third_party/WebKit/PerformanceTests/resources/runner.js View 5 chunks +3 lines, -44 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.js View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 4 chunks +1 line, -101 lines 0 comments Download
D tools/perf/benchmarks/blink_perf_unittest.py View 1 chunk +0 lines, -156 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
alph
Created Revert of Support tracing metrics for measureTime & measureFrameTime method in blink_perf
3 years, 8 months ago (2017-04-26 22:03:12 UTC) #2
nednguyen
On 2017/04/26 22:03:12, alph wrote: > Created Revert of Support tracing metrics for measureTime & ...
3 years, 8 months ago (2017-04-26 22:07:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844873002/1
3 years, 8 months ago (2017-04-26 22:59:01 UTC) #6
alph
On 2017/04/26 22:07:30, nednguyen wrote: > On 2017/04/26 22:03:12, alph wrote: > > Created Revert ...
3 years, 8 months ago (2017-04-26 22:59:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c4abf7fbfae66c20c30fdce1c95827e687cd4976
3 years, 8 months ago (2017-04-26 23:01:23 UTC) #10
alph
3 years, 8 months ago (2017-04-26 23:13:49 UTC) #11
Message was sent while issue was closed.
On 2017/04/26 23:01:23, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/c4abf7fbfae66c20c30fdce1c958...

The right link to the failing bot
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%2...

Powered by Google App Engine
This is Rietveld 408576698