Support tracing metrics for measureTime & measureFrameTime method in blink_perf

Support tracing metrics for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

If a test has "tracingCategories" & "traceEventsToMeasure" fields 
specified, Telemetry will enable the specified tracing categories &
compute the cpu time of all the specified trace events (one per test 
run).

Detailed examples of how to use this new API are in third_party/WebKit/PerformanceTests/TestData/


BUG=701059
Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing --story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000, 2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000, 5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000, 6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000, 30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.

Review-Url: https://codereview.chromium.org/2819343002
Cr-Commit-Position: refs/heads/master@{#467445}
Committed: https://chromium.googlesource.com/chromium/src/+/0d2d43615b4553f00ac711f54dbcc0835f04366b

[nednguyen, 2017-04-19 12:56:41]

Description was changed from

==========
Initial work

BUG=
==========

to

==========
Blink perf tracing [WIP]
BUG=
==========

[nednguyen, 2017-04-19 15:25:42]

Patchset #1 (id:1) has been deleted

[nednguyen, 2017-04-19 15:25:47]

Patchset #1 (id:20001) has been deleted

[nednguyen, 2017-04-19 15:25:53]

Patchset #1 (id:40001) has been deleted

[nednguyen, 2017-04-19 15:25:57]

Patchset #1 (id:50001) has been deleted

[nednguyen, 2017-04-19 15:26:05]

Patchset #1 (id:70001) has been deleted

[nednguyen, 2017-04-19 15:26:10]

Patchset #1 (id:90001) has been deleted

[nednguyen, 2017-04-19 15:26:15]

Patchset #1 (id:110001) has been deleted

[nednguyen, 2017-04-19 15:28:08]

Description was changed from

==========
Blink perf tracing [WIP]
BUG=
==========

to

==========
Support tracing for measureTime & measureFrameTime method in blink_perf

BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.layout
--story-filter=measure --output-format=json --output-format=html
==========

[nednguyen, 2017-04-19 18:07:07]

Description was changed from

==========
Support tracing for measureTime & measureFrameTime method in blink_perf

BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.layout
--story-filter=measure --output-format=json --output-format=html
==========

to

==========
Support tracing for measureTime & measureFrameTime method in blink_perf

BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
==========

[nednguyen, 2017-04-19 18:08:56]

Description was changed from

==========
Support tracing for measureTime & measureFrameTime method in blink_perf

BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
==========

to

==========
Support tracing for measureTime & measureFrameTime method in blink_perf

BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
...
==========

[nednguyen, 2017-04-19 19:04:20]

Description was changed from

==========
Support tracing for measureTime & measureFrameTime method in blink_perf

BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
...
==========

to

==========
Support tracing for measureTime & measureFrameTime method in blink_perf

BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

[nednguyen, 2017-04-19 19:05:29]

Description was changed from

==========
Support tracing for measureTime & measureFrameTime method in blink_perf

BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

to

==========
Support tracing for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

Examples of how to use this are in blink_perf/TestData/


BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

[nednguyen, 2017-04-19 19:08:27]

Description was changed from

==========
Support tracing for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

Examples of how to use this are in blink_perf/TestData/


BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

to

==========
Support tracing for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

If a test has "tracingCategories" & "traceEventsToMeasure" fields 
specified, Telemetry will enable the specified tracing categories &
compute the cpu time of all the specified trace events (one per test 
run).

Detailed examples of how to use this new API are in
third_party/WebKit/PerformanceTests/TestData/


BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

[nednguyen, 2017-04-19 19:08:27]

nednguyen@google.com changed reviewers:
+ haraken@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org

[nednguyen, 2017-04-19 19:09:23]

PTAL. I haven't added much unittests, please let me know if the high level
direction look ok to you. One the high level are sorted out, I will add more
tests

[nednguyen, 2017-04-19 19:09:32]

Description was changed from

==========
Support tracing for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

If a test has "tracingCategories" & "traceEventsToMeasure" fields 
specified, Telemetry will enable the specified tracing categories &
compute the cpu time of all the specified trace events (one per test 
run).

Detailed examples of how to use this new API are in
third_party/WebKit/PerformanceTests/TestData/


BUG=701059

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

to

==========
Support tracing for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

If a test has "tracingCategories" & "traceEventsToMeasure" fields 
specified, Telemetry will enable the specified tracing categories &
compute the cpu time of all the specified trace events (one per test 
run).

Detailed examples of how to use this new API are in
third_party/WebKit/PerformanceTests/TestData/


BUG=701059


Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

[nednguyen, 2017-04-19 19:09:45]

Patchset #3 (id:170001) has been deleted

[nednguyen, 2017-04-19 19:11:22]

Description was changed from

==========
Support tracing for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

If a test has "tracingCategories" & "traceEventsToMeasure" fields 
specified, Telemetry will enable the specified tracing categories &
compute the cpu time of all the specified trace events (one per test 
run).

Detailed examples of how to use this new API are in
third_party/WebKit/PerformanceTests/TestData/


BUG=701059


Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

to

==========
Support tracing metrics for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

If a test has "tracingCategories" & "traceEventsToMeasure" fields 
specified, Telemetry will enable the specified tracing categories &
compute the cpu time of all the specified trace events (one per test 
run).

Detailed examples of how to use this new API are in
third_party/WebKit/PerformanceTests/TestData/


BUG=701059


Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

[nednguyen, 2017-04-19 19:12:21]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 19:13:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 19:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 19:23:53]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nednguyen, 2017-04-21 00:14:37]

On 2017/04/19 19:09:23, nednguyen wrote:
> PTAL. I haven't added much unittests, please let me know if the high level
> direction look ok to you. One the high level are sorted out, I will add more
> tests

Ping.

[Xianzhu, 2017-04-21 01:31:51]

The CL looks great!

https://codereview.chromium.org/2819343002/diff/190001/third_party/WebKit/Per...
File third_party/WebKit/PerformanceTests/resources/runner.js (right):

https://codereview.chromium.org/2819343002/diff/190001/third_party/WebKit/Per...
third_party/WebKit/PerformanceTests/resources/runner.js:163:
window.testRunner.traceEventsToMeasure = test.traceEventsToMeasure;
Nit: Use indentation (4) consistent with the original code.

https://codereview.chromium.org/2819343002/diff/190001/third_party/WebKit/Per...
third_party/WebKit/PerformanceTests/resources/runner.js:260: if
(window.testRunner === undefined || !window.testRunner.supportTracing)
Nit: !window.testRunner?

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
File tools/perf/benchmarks/blink_perf.js (right):

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
tools/perf/benchmarks/blink_perf.js:24: testRunner.startTracing =
function(tracingCategories, scheduleTestRun) {
Why traceEventsToMeasure is set as a variable while tracingCategories is passed
as a parameter? Can you pass both as parameters?

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
File tools/perf/benchmarks/blink_perf.py (right):

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
tools/perf/benchmarks/blink_perf.py:142: curr_test_runs_bound_index +=  1
Nit: remove extra space before '1'.

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
tools/perf/benchmarks/blink_perf.py:174: 'testRunner.isDone ||
testRunner.isWaitingForTracingStart', timeout=600)
Nit: indent

[nednguyen, 2017-04-24 20:55:22]

https://codereview.chromium.org/2819343002/diff/190001/third_party/WebKit/Per...
File third_party/WebKit/PerformanceTests/resources/runner.js (right):

https://codereview.chromium.org/2819343002/diff/190001/third_party/WebKit/Per...
third_party/WebKit/PerformanceTests/resources/runner.js:163:
window.testRunner.traceEventsToMeasure = test.traceEventsToMeasure;
On 2017/04/21 01:31:51, Xianzhu wrote:
> Nit: Use indentation (4) consistent with the original code. 

Done.

https://codereview.chromium.org/2819343002/diff/190001/third_party/WebKit/Per...
third_party/WebKit/PerformanceTests/resources/runner.js:260: if
(window.testRunner === undefined || !window.testRunner.supportTracing)
On 2017/04/21 01:31:51, Xianzhu wrote:
> Nit: !window.testRunner?

Done.

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
File tools/perf/benchmarks/blink_perf.js (right):

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
tools/perf/benchmarks/blink_perf.js:24: testRunner.startTracing =
function(tracingCategories, scheduleTestRun) {
On 2017/04/21 01:31:51, Xianzhu wrote:
> Why traceEventsToMeasure is set as a variable while tracingCategories is
passed
> as a parameter? Can you pass both as parameters?

I want to keep startTracing to be focused on setting up the trace events
required. To make the code clearer, I can refactor it to:
testRunner.startTracing(tracingCategories, scheduleTestRun) {}
testRunner.stopTracingAndMeasure(traceEventsToMeasure, callback)

wdyt?

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
File tools/perf/benchmarks/blink_perf.py (right):

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
tools/perf/benchmarks/blink_perf.py:142: curr_test_runs_bound_index +=  1
On 2017/04/21 01:31:51, Xianzhu wrote:
> Nit: remove extra space before '1'.

Done.

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
tools/perf/benchmarks/blink_perf.py:174: 'testRunner.isDone ||
testRunner.isWaitingForTracingStart', timeout=600)
On 2017/04/21 01:31:51, Xianzhu wrote:
> Nit: indent

Done.

[Xianzhu, 2017-04-24 21:03:07]

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
File tools/perf/benchmarks/blink_perf.js (right):

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
tools/perf/benchmarks/blink_perf.js:24: testRunner.startTracing =
function(tracingCategories, scheduleTestRun) {
On 2017/04/24 20:55:21, nednguyen wrote:
> On 2017/04/21 01:31:51, Xianzhu wrote:
> > Why traceEventsToMeasure is set as a variable while tracingCategories is
> passed
> > as a parameter? Can you pass both as parameters?
> 
> I want to keep startTracing to be focused on setting up the trace events
> required. To make the code clearer, I can refactor it to:
> testRunner.startTracing(tracingCategories, scheduleTestRun) {}
> testRunner.stopTracingAndMeasure(traceEventsToMeasure, callback)
> 
> wdyt?

SGTM.

[nednguyen, 2017-04-24 22:31:41]

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
File tools/perf/benchmarks/blink_perf.js (right):

https://codereview.chromium.org/2819343002/diff/190001/tools/perf/benchmarks/...
tools/perf/benchmarks/blink_perf.js:24: testRunner.startTracing =
function(tracingCategories, scheduleTestRun) {
On 2017/04/24 21:03:07, Xianzhu wrote:
> On 2017/04/24 20:55:21, nednguyen wrote:
> > On 2017/04/21 01:31:51, Xianzhu wrote:
> > > Why traceEventsToMeasure is set as a variable while tracingCategories is
> > passed
> > > as a parameter? Can you pass both as parameters?
> > 
> > I want to keep startTracing to be focused on setting up the trace events
> > required. To make the code clearer, I can refactor it to:
> > testRunner.startTracing(tracingCategories, scheduleTestRun) {}
> > testRunner.stopTracingAndMeasure(traceEventsToMeasure, callback)
> > 
> > wdyt?
> 
> SGTM.

Done.

[nednguyen, 2017-04-24 22:34:18]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 22:35:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-04-24 22:37:35]

https://codereview.chromium.org/2819343002/diff/230001/third_party/WebKit/Per...
File third_party/WebKit/PerformanceTests/resources/runner.js (right):

https://codereview.chromium.org/2819343002/diff/230001/third_party/WebKit/Per...
third_party/WebKit/PerformanceTests/resources/runner.js:240:
currentTest.traceEventsToMeasure, function() {
not sure why but here, I can't just put
"testRunner.stopTracingAndMeasure(currentTest.traceEventsToMeasure,
testRunner.notifyDone)". If someone who is more familiar with JS can enlighten
me on this, I would really appreciate it.  :P

[commit-bot: I haz the power, 2017-04-24 22:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 22:45:41]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Xianzhu, 2017-04-24 22:46:04]

lgtm

https://codereview.chromium.org/2819343002/diff/230001/third_party/WebKit/Per...
File third_party/WebKit/PerformanceTests/resources/runner.js (right):

https://codereview.chromium.org/2819343002/diff/230001/third_party/WebKit/Per...
third_party/WebKit/PerformanceTests/resources/runner.js:240:
currentTest.traceEventsToMeasure, function() {
On 2017/04/24 22:37:34, nednguyen wrote:
> not sure why but here, I can't just put
> "testRunner.stopTracingAndMeasure(currentTest.traceEventsToMeasure,
> testRunner.notifyDone)". If someone who is more familiar with JS can enlighten
> me on this, I would really appreciate it.  :P

topTracingAndMeasure(..., testRunner.notifyDone) doesn't work because callback
will be called as a function without an object so notifyDone() will have no
'this' object.

https://codereview.chromium.org/2819343002/diff/230001/tools/perf/benchmarks/...
File tools/perf/benchmarks/blink_perf.js (right):

https://codereview.chromium.org/2819343002/diff/230001/tools/perf/benchmarks/...
tools/perf/benchmarks/blink_perf.js:29: testRunner.traceEventsToMeasure =
traceEventsToMeasure;
Nit: s/testRunner/this/ to be consistent with startTracing().

[haraken, 2017-04-25 17:30:57]

(I'll defer this review to wangxianzhu@)

[nednguyen, 2017-04-25 17:33:13]

On 2017/04/25 17:30:57, haraken wrote:
> (I'll defer this review to wangxianzhu@)

Thanks. pdr@ do you want to take a look too? If not, I will add  more unittest
for the code that computes tracing based metrics & land this CL.

[nednguyen, 2017-04-26 13:58:26]

On 2017/04/25 17:33:13, nednguyen wrote:
> On 2017/04/25 17:30:57, haraken wrote:
> > (I'll defer this review to wangxianzhu@)
> 
> Thanks. pdr@ do you want to take a look too? If not, I will add  more unittest
> for the code that computes tracing based metrics & land this CL.

I added tests for the tracing metrics computation. Landing now..

[nednguyen, 2017-04-26 13:58:47]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-04-26 13:58:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2819343002/#ps250001
(title: "Added blink_perf tracing metrics test")

[commit-bot: I haz the power, 2017-04-26 13:59:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 15:57:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 15:57:01]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nednguyen, 2017-04-26 16:06:39]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2017-04-26 16:07:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 18:03:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 18:03:57]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nednguyen, 2017-04-26 18:27:52]

testBlinkPerfTracingMetricsForMeasureTime keeps failing on linux_android_rel_ng,
so I am disabling it to land this.

Filed crbug.com/715685

[nednguyen, 2017-04-26 18:29:35]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-04-26 18:29:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2819343002/#ps270001
(title: "Disable testBlinkPerfTracingMetricsForMeasureTime on Android")

[commit-bot: I haz the power, 2017-04-26 18:30:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 20:45:15]

CQ is committing da patch.

Bot data: {"patchset_id": 270001, "attempt_start_ts": 1493231375584960,
"parent_rev": "9371e23b8b90027373ba8c27f60698ee42ef94dd", "commit_rev":
"0d2d43615b4553f00ac711f54dbcc0835f04366b"}

[commit-bot: I haz the power, 2017-04-26 20:45:28]

Description was changed from

==========
Support tracing metrics for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

If a test has "tracingCategories" & "traceEventsToMeasure" fields 
specified, Telemetry will enable the specified tracing categories &
compute the cpu time of all the specified trace events (one per test 
run).

Detailed examples of how to use this new API are in
third_party/WebKit/PerformanceTests/TestData/


BUG=701059


Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.
==========

to

==========
Support tracing metrics for measureTime & measureFrameTime methods in blink_perf

This CL adds support for tracing metrics with measureTime & 
measureFrameTime methods in blink_perf harness.

If a test has "tracingCategories" & "traceEventsToMeasure" fields 
specified, Telemetry will enable the specified tracing categories &
compute the cpu time of all the specified trace events (one per test 
run).

Detailed examples of how to use this new API are in
third_party/WebKit/PerformanceTests/TestData/


BUG=701059


Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing
--story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000,
2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000,
5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000,
6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000,
30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.

Review-Url: https://codereview.chromium.org/2819343002
Cr-Commit-Position: refs/heads/master@{#467445}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d2d43615b4553f00ac711f54dbc...
==========

[commit-bot: I haz the power, 2017-04-26 20:45:29]

Committed patchset #7 (id:270001) as
https://chromium.googlesource.com/chromium/src/+/0d2d43615b4553f00ac711f54dbc...

[alph, 2017-04-26 22:03:11]

A revert of this CL (patchset #7 id:270001) has been created in
https://codereview.chromium.org/2844873002/ by alph@chromium.org.

The reason for reverting is: Seems to broke telemetry tests
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2....

[alph, 2017-04-26 23:14:23]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2017-04-26 23:14:24]

The right link to the failing bot:
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%2...