Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2844743002: Revert of [EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
sacomoto, Tim Song
CC:
chromium-reviews, extensions-reviews_chromium.org, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, chromium-apps-reviews_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs. (patchset #8 id:140001 of https://codereview.chromium.org/2841743003/ ) Reason for revert: Looks like this causes static initializers: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F38433%2F%2B%2Frecipes%2Fsteps%2Fsizes%2F0%2Fstdout Original issue's description: > [EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs. > > Note that this CL copies this class to the proximity_auth/ directory. The existing BLE directory will be deleted in the future, as it is obsolete. > > Review-Url: https://codereview.chromium.org/2841743003 > Cr-Original-Commit-Position: refs/heads/master@{#467190} > Committed: https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b273801b20e7422 > Review-Url: https://codereview.chromium.org/2841743003 > Cr-Commit-Position: refs/heads/master@{#467354} > Committed: https://chromium.googlesource.com/chromium/src/+/2202d101776a980e3dd97f9b47b946d55dc562e6 TBR=sacomoto@chromium.org,tengs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2844743002 Cr-Commit-Position: refs/heads/master@{#467365} Committed: https://chromium.googlesource.com/chromium/src/+/7c5e2d42f4618591199976acb8da1e3bc1648095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1033 lines, -891 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M components/cryptauth/background_eid_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/BUILD.gn View 4 chunks +7 lines, -4 lines 0 comments Download
M components/proximity_auth/ble/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h View 1 chunk +171 lines, -0 lines 0 comments Download
A components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc View 1 chunk +319 lines, -0 lines 0 comments Download
A components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc View 1 chunk +509 lines, -0 lines 0 comments Download
D components/proximity_auth/bluetooth_low_energy_connection_finder.h View 1 chunk +0 lines, -148 lines 0 comments Download
D components/proximity_auth/bluetooth_low_energy_connection_finder.cc View 1 chunk +0 lines, -280 lines 0 comments Download
D components/proximity_auth/bluetooth_low_energy_connection_finder_unittest.cc View 1 chunk +0 lines, -434 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 5 chunks +9 lines, -22 lines 0 comments Download
M components/proximity_auth/webui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Nico
Created Revert of [EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.
3 years, 8 months ago (2017-04-26 17:37:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844743002/1
3 years, 8 months ago (2017-04-26 17:38:04 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 17:38:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c5e2d42f4618591199976acb8da...

Powered by Google App Engine
This is Rietveld 408576698