[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Original-Original-Commit-Position: refs/heads/master@{#467190}
Committed: https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b273801b20e7422
Review-Url: https://codereview.chromium.org/2841743003
Cr-Original-Commit-Position: refs/heads/master@{#467354}
Committed: https://chromium.googlesource.com/chromium/src/+/2202d101776a980e3dd97f9b47b946d55dc562e6
Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467482}
Committed: https://chromium.googlesource.com/chromium/src/+/3dc61d2347368913d1c0aa493cdb887f08ae681e

[Tim Song, 2017-04-24 23:42:50]

Description was changed from

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

This CL cleans up unnecessary BLE code from our old protocol, and updates the
connection finder to check for the EIDs advertised by the phone.
==========

to

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.
==========

[Tim Song, 2017-04-24 23:50:43]

tengs@chromium.org changed reviewers:
+ sacomoto@chromium.org

[sacomoto, 2017-04-25 09:45:00]

https://codereview.chromium.org/2841743003/diff/40001/components/proximity_au...
File components/proximity_auth/bluetooth_low_energy_connection_finder.cc
(right):

https://codereview.chromium.org/2841743003/diff/40001/components/proximity_au...
components/proximity_auth/bluetooth_low_energy_connection_finder.cc:92: return;
I think this is a bit awkward. This method is a no-op if we fail to fetch the
seeds, and the upper layers are not notified. 

I see two ways to fix this. Either pass a seed array directly (and require it to
be non-empty), or have a (persistent) failure callback in this method.

https://codereview.chromium.org/2841743003/diff/40001/components/proximity_au...
components/proximity_auth/bluetooth_low_energy_connection_finder.cc:94:
nearest_eids_ = eid_generator_->GenerateNearestEids(beacon_seeds);
Shouldn't we recompute this periodically? What if the screen is locked for more
than 45min?

[Tim Song, 2017-04-25 20:37:47]

https://codereview.chromium.org/2841743003/diff/40001/components/proximity_au...
File components/proximity_auth/bluetooth_low_energy_connection_finder.cc
(right):

https://codereview.chromium.org/2841743003/diff/40001/components/proximity_au...
components/proximity_auth/bluetooth_low_energy_connection_finder.cc:92: return;
On 2017/04/25 09:45:00, sacomoto wrote:
> I think this is a bit awkward. This method is a no-op if we fail to fetch the
> seeds, and the upper layers are not notified. 
> 
> I see two ways to fix this. Either pass a seed array directly (and require it
to
> be non-empty), or have a (persistent) failure callback in this method. 
> 

I changed the interface to accept the BeaconSeeds directly, but there is no real
change in behaviour, because RemoteDeviceLifeCycle isn't designed to deal with
invalid device data.

There's also a few other places in this class where we just idle if something
fails. I think this behaviour is okay, as these are very exceptional cases.

https://codereview.chromium.org/2841743003/diff/40001/components/proximity_au...
components/proximity_auth/bluetooth_low_energy_connection_finder.cc:94:
nearest_eids_ = eid_generator_->GenerateNearestEids(beacon_seeds);
On 2017/04/25 09:45:00, sacomoto wrote:
> Shouldn't we recompute this periodically? What if the screen is locked for
more
> than 45min?

This should be very unlikely as the Chromebook will suspend after some minutes
of inactivity.

However, I changed this class to recompute the EIDs for each device update. It's
less efficient, but it's not really something we need to optimize for.

[sacomoto, 2017-04-25 20:48:23]

lgtm

[Tim Song, 2017-04-25 21:43:51]

The CQ bit was checked by tengs@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:44:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 21:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:51:07]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tim Song, 2017-04-25 22:14:28]

The CQ bit was checked by tengs@chromium.org

[Tim Song, 2017-04-25 22:14:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
sacomoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2841743003/#ps80001
(title: "fix compile issues")

[commit-bot: I haz the power, 2017-04-25 22:15:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:22:30]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tim Song, 2017-04-25 22:47:50]

The CQ bit was checked by tengs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 22:48:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:53:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tim Song, 2017-04-25 23:30:33]

The CQ bit was checked by tengs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 23:31:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:43:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:43:17]

Dry run: This issue passed the CQ dry run.

[Tim Song, 2017-04-26 00:57:22]

The CQ bit was checked by tengs@chromium.org

[Tim Song, 2017-04-26 00:57:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
sacomoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2841743003/#ps120001
(title: "fix BUILD.gn")

[commit-bot: I haz the power, 2017-04-26 00:58:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 01:04:01]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1493168242436430,
"parent_rev": "cb7ad92fe2a8bd9561264169b6765c75e82eea23", "commit_rev":
"4e46b4e06866f12f15eb9f436b273801b20e7422"}

[commit-bot: I haz the power, 2017-04-26 01:04:35]

Description was changed from

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.
==========

to

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467190}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...
==========

[commit-bot: I haz the power, 2017-04-26 01:04:41]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...

[sashab, 2017-04-26 02:28:15]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2845473002/ by sashab@chromium.org.

The reason for reverting is: Suspected cause of failed sizes check in
https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/3....

[Tim Song, 2017-04-26 15:44:56]

Description was changed from

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467190}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...
==========

to

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467190}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...
==========

[Tim Song, 2017-04-26 15:46:28]

The CQ bit was checked by tengs@chromium.org

[Tim Song, 2017-04-26 15:46:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
sacomoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2841743003/#ps140001
(title: "remote static initializer")

[Tim Song, 2017-04-26 15:46:46]

Removed the static initializer. Resubmitting.

[Tim Song, 2017-04-26 15:46:46]

Removed the static initializer. Resubmitting.

[commit-bot: I haz the power, 2017-04-26 15:47:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 17:06:27]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493221588846480,
"parent_rev": "d7119231dcd23626b491d050706871c2729601a3", "commit_rev":
"2202d101776a980e3dd97f9b47b946d55dc562e6"}

[commit-bot: I haz the power, 2017-04-26 17:06:39]

Description was changed from

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467190}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...
==========

to

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Original-Commit-Position: refs/heads/master@{#467190}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...
Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467354}
Committed:
https://chromium.googlesource.com/chromium/src/+/2202d101776a980e3dd97f9b47b9...
==========

[commit-bot: I haz the power, 2017-04-26 17:06:40]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/2202d101776a980e3dd97f9b47b9...

[Nico, 2017-04-26 17:37:08]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2844743002/ by thakis@chromium.org.

The reason for reverting is: Looks like this causes static initializers:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F3....

[Tim Song, 2017-04-26 22:18:11]

Description was changed from

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Original-Commit-Position: refs/heads/master@{#467190}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...
Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467354}
Committed:
https://chromium.googlesource.com/chromium/src/+/2202d101776a980e3dd97f9b47b9...
==========

to

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Original-Commit-Position: refs/heads/master@{#467190}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...
Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467354}
Committed:
https://chromium.googlesource.com/chromium/src/+/2202d101776a980e3dd97f9b47b9...
==========

[Tim Song, 2017-04-26 22:19:02]

I didn't realize there were more static initializers...

I should have fixed all of them in
https://codereview.chromium.org/2844773002

[Tim Song, 2017-04-26 22:19:09]

The CQ bit was checked by tengs@chromium.org

[commit-bot: I haz the power, 2017-04-26 22:19:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 22:25:56]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493245149409020,
"parent_rev": "66af3190419dfd8dbc5f8e480ccc049f8e513e08", "commit_rev":
"3dc61d2347368913d1c0aa493cdb887f08ae681e"}

[commit-bot: I haz the power, 2017-04-26 22:26:10]

Description was changed from

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Original-Commit-Position: refs/heads/master@{#467190}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...
Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467354}
Committed:
https://chromium.googlesource.com/chromium/src/+/2202d101776a980e3dd97f9b47b9...
==========

to

==========
[EasyUnlock] Update BluetoothLowEnergyConnectionFinder to look for EIDs.

Note that this CL copies this class to the proximity_auth/ directory. The
existing BLE directory will be deleted in the future, as it is obsolete.

Review-Url: https://codereview.chromium.org/2841743003
Cr-Original-Original-Commit-Position: refs/heads/master@{#467190}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e46b4e06866f12f15eb9f436b27...
Review-Url: https://codereview.chromium.org/2841743003
Cr-Original-Commit-Position: refs/heads/master@{#467354}
Committed:
https://chromium.googlesource.com/chromium/src/+/2202d101776a980e3dd97f9b47b9...
Review-Url: https://codereview.chromium.org/2841743003
Cr-Commit-Position: refs/heads/master@{#467482}
Committed:
https://chromium.googlesource.com/chromium/src/+/3dc61d2347368913d1c0aa493cdb...
==========

[commit-bot: I haz the power, 2017-04-26 22:26:12]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/3dc61d2347368913d1c0aa493cdb...