Remove blink_perf.pywebsocket tests

Remove blink_perf.pywebsocket tests

These were tests for WebSocket, XHR and fetch bandwidth. They produced a large
number of false positives and so had been disabled on the bots. Since there is
no-one available to care for these tests, remove them.

BUG=551950, 549017, 715500
Review-Url: https://codereview.chromium.org/2844633002
Cr-Commit-Position: refs/heads/master@{#468312}
Committed: https://chromium.googlesource.com/chromium/src/+/6474e28997d82bd16590b24c0371671b525fdd5a

[Adam Rice, 2017-04-26 07:57:45]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 07:58:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-04-26 07:58:55]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 07:59:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 10:37:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 10:37:25]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2017-04-27 02:28:46]

ricea@chromium.org changed reviewers:
+ tyoshino@chromium.org

[Adam Rice, 2017-04-27 03:12:27]

Description was changed from

==========
Remove blink_perf.pywebsocket tests

These were tests for WebSocket, XHR and fetch bandwidth. They produced a large
number of false positives and so had been disabled on the bots. Since there is
no-one available to care for these tests, remove them.

BUG=551950,549017
==========

to

==========
Remove blink_perf.pywebsocket tests

These were tests for WebSocket, XHR and fetch bandwidth. They produced a large
number of false positives and so had been disabled on the bots. Since there is
no-one available to care for these tests, remove them.

BUG=551950,549017,715500
==========

[tyoshino (SeeGerritForStatus), 2017-04-27 07:11:47]

Looks good.

chromium.perf.json includes a lot of unrelated diffs. Is this because you had to
run some lint stuff and it shuffled them?

[tyoshino (SeeGerritForStatus), 2017-04-27 07:12:15]

Added some note how to revive the tests to the public team doc.
https://docs.google.com/document/d/1PN8RN9NESiOtVzMWZf1f94H85Nf6Sfs9Lc9xgAsjV...

[Adam Rice, 2017-04-27 07:32:22]

On 2017/04/27 07:11:47, tyoshino wrote:
> Looks good.
> 
> chromium.perf.json includes a lot of unrelated diffs. Is this because you had
to
> run some lint stuff and it shuffled them?

Sorry, I didn't notice that.

What happened is that I ran //tools/perf/generate_perf_data.py as the comment as
the top of //tools/perf/benchmark.csv requested. It looks like no-one had run it
in a while and so some other changes ended up included.

Perhaps I should revert the changes that are not pywebsocket-related and then
create a separate CL to apply them?

[tyoshino (SeeGerritForStatus), 2017-04-27 07:38:46]

On 2017/04/27 07:32:22, Adam Rice wrote:
> On 2017/04/27 07:11:47, tyoshino wrote:
> > Looks good.
> > 
> > chromium.perf.json includes a lot of unrelated diffs. Is this because you
had
> to
> > run some lint stuff and it shuffled them?
> 
> Sorry, I didn't notice that.
> 
> What happened is that I ran //tools/perf/generate_perf_data.py as the comment
as
> the top of //tools/perf/benchmark.csv requested. It looks like no-one had run
it
> in a while and so some other changes ended up included.

Ohh, I see...

> 
> Perhaps I should revert the changes that are not pywebsocket-related and then
> create a separate CL to apply them?

Yeah, that would be better given the large diff, I think. You can also choose to
just ask the OWNERS of the file to review it what to do with as we anyway need
to get their l-g-t-m.

lgtm

[Adam Rice, 2017-04-28 10:47:45]

message: On 2017/04/27 07:32:22, Adam Rice wrote:
> What happened is that I ran //tools/perf/generate_perf_data.py as the comment
as
> the top of //tools/perf/benchmark.csv requested. It looks like no-one had run
it
> in a while and so some other changes ended up included.

It's not what I thought. The files are so large that git cl upload won't upload
the originals, so I have to make sure my local upstream exactly matches ToT to
get the diff in Rietveld right.

Sorry for the confusion.

[tyoshino (SeeGerritForStatus), 2017-04-28 10:50:22]

On 2017/04/28 10:47:45, Adam Rice wrote:
> message: On 2017/04/27 07:32:22, Adam Rice wrote:
> > What happened is that I ran //tools/perf/generate_perf_data.py as the
comment
> as
> > the top of //tools/perf/benchmark.csv requested. It looks like no-one had
run
> it
> > in a while and so some other changes ended up included.
> 
> It's not what I thought. The files are so large that git cl upload won't
upload
> the originals, so I have to make sure my local upstream exactly matches ToT to
> get the diff in Rietveld right.
> 
> Sorry for the confusion.

Oh, interesting. Got it.

[Adam Rice, 2017-04-28 10:51:44]

ricea@chromium.org changed reviewers:
+ nednguyen@google.com

[Adam Rice, 2017-04-28 10:51:45]

+nednguyen for OWNERS review.

The diff for testing/buildbot/chromium.perf.json on Rietveld contains changes
that are not in my local repository. I thought you might have experience with
this problem and know what to do about it.

[nednguyen, 2017-04-28 12:32:00]

lgtm

Thanks!

[Adam Rice, 2017-04-28 12:32:54]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2017-04-28 12:32:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org
Link to the patchset: https://codereview.chromium.org/2844633002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-28 12:33:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 15:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:05:17]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Adam Rice, 2017-05-01 12:11:18]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2017-05-01 12:11:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 14:12:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493640678060760,
"parent_rev": "c23bfaa3ae9f6898df8386120c592b6018d09b6f", "commit_rev":
"6474e28997d82bd16590b24c0371671b525fdd5a"}

[commit-bot: I haz the power, 2017-05-01 14:12:31]

Description was changed from

==========
Remove blink_perf.pywebsocket tests

These were tests for WebSocket, XHR and fetch bandwidth. They produced a large
number of false positives and so had been disabled on the bots. Since there is
no-one available to care for these tests, remove them.

BUG=551950,549017,715500
==========

to

==========
Remove blink_perf.pywebsocket tests

These were tests for WebSocket, XHR and fetch bandwidth. They produced a large
number of false positives and so had been disabled on the bots. Since there is
no-one available to care for these tests, remove them.

BUG=551950,549017,715500

Review-Url: https://codereview.chromium.org/2844633002
Cr-Commit-Position: refs/heads/master@{#468312}
Committed:
https://chromium.googlesource.com/chromium/src/+/6474e28997d82bd16590b24c0371...
==========

[commit-bot: I haz the power, 2017-05-01 14:12:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6474e28997d82bd16590b24c0371...