Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 2844633002: Remove blink_perf.pywebsocket tests (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/benchmarks/pywebsocket_server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/blink_perf.py
diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py
index d75a0561c669d44cd16f4c4b71a274ffcfa871da..cb167cea3b21320907e05272e86f5e9befc1d1ef 100644
--- a/tools/perf/benchmarks/blink_perf.py
+++ b/tools/perf/benchmarks/blink_perf.py
@@ -21,7 +21,6 @@ from telemetry.value import scalar
from telemetry.value import trace
-from benchmarks import pywebsocket_server
from measurements import timeline_controller
from page_sets import webgl_supported_shared_state
@@ -278,15 +277,6 @@ class _BlinkPerfBenchmark(perf_benchmark.PerfBenchmark):
return CreateStorySetFromPath(path, SKIPPED_FILE)
-class _SharedPywebsocketPageState(shared_page_state.SharedPageState):
- """Runs a pywebsocket server."""
-
- def __init__(self, test, finder_options, user_story_set):
- super(_SharedPywebsocketPageState, self).__init__(
- test, finder_options, user_story_set)
- self.platform.StartLocalServer(pywebsocket_server.PywebsocketServer())
-
-
@benchmark.Owner(emails=['yukishiino@chromium.org',
'bashi@chromium.org',
'haraken@chromium.org'])
@@ -400,28 +390,3 @@ class BlinkPerfShadowDOM(_BlinkPerfBenchmark):
def ShouldDisable(cls, possible_browser): # http://crbug.com/702319
return possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'
-
-
-# Disabled on Windows and ChromeOS due to https://crbug.com/521887
-#@benchmark.Disabled('win', 'chromeos')
-# Disabling on remaining platforms due to heavy flake https://crbug.com/646938
-@benchmark.Disabled('all')
-@benchmark.Owner(emails=['tyoshino@chromium.org', 'yhirano@chromium.org'])
-class BlinkPerfPywebsocket(_BlinkPerfBenchmark):
- """The blink_perf.pywebsocket tests measure turn-around-time of 10MB
- send/receive for XHR, Fetch API and WebSocket. We might ignore < 10%
- regressions, because the tests are noisy and such regressions are
- often unreproducible (https://crbug.com/549017).
- """
- tag = 'pywebsocket'
- subdir = 'Pywebsocket'
-
- def CreateStorySet(self, options):
- path = os.path.join(BLINK_PERF_BASE_DIR, self.subdir)
- return CreateStorySetFromPath(
- path, SKIPPED_FILE,
- shared_page_state_class=_SharedPywebsocketPageState)
-
- @classmethod
- def ShouldDisable(cls, possible_browser):
- return cls.IsSvelte(possible_browser) # http://crbug.com/551950
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/benchmarks/pywebsocket_server.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698