Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2844623002: Revert of Optimize check_gn_headers.py for speed (Closed)

Created:
2 years, 9 months ago by wychen
Modified:
2 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Optimize check_gn_headers.py for speed (patchset #1 id:1 of https://codereview.chromium.org/2842513003/ ) Reason for revert: This optimization was buggy and broke the ninja parsing. Original issue's description: > Optimize check_gn_headers.py for speed > > Process the output of 'ninja' live through the pipe rather than waiting > for it to finish. > > Before: > 20.74user 16.36system 0:24.57elapsed 151%CPU > > After: > 16.63user 9.24system 0:13.94elapsed 185%CPU > > BUG=661774 > > Review-Url: https://codereview.chromium.org/2842513003 > Cr-Commit-Position: refs/heads/master@{#466900} > Committed: https://chromium.googlesource.com/chromium/src/+/6b609383cf3669b0670b567249ff868ea4b26e43 TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661774 Review-Url: https://codereview.chromium.org/2844623002 Cr-Commit-Position: refs/heads/master@{#467231} Committed: https://chromium.googlesource.com/chromium/src/+/c219b8a1823f884703c3546bf2cb7c17fb737d67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M build/check_gn_headers.py View 2 chunks +2 lines, -16 lines 0 comments Download
M build/check_gn_headers_unittest.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
wychen
Created Revert of Optimize check_gn_headers.py for speed
2 years, 9 months ago (2017-04-26 04:09:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844623002/1
2 years, 9 months ago (2017-04-26 04:09:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c219b8a1823f884703c3546bf2cb7c17fb737d67
2 years, 9 months ago (2017-04-26 04:10:41 UTC) #6
Dirk Pranke
lgtm
2 years, 9 months ago (2017-04-26 04:29:40 UTC) #7
wychen
2 years, 9 months ago (2017-04-26 04:30:30 UTC) #8
Message was sent while issue was closed.
On 2017/04/26 04:29:40, Dirk Pranke wrote:
> lgtm

Sorry, should've double checked when cherry-picking from an ancient local
branch.

Powered by Google App Engine
This is Rietveld 408576698