Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(30)

Issue 2842513003: Optimize check_gn_headers.py for speed (Closed)

Created:
3 years, 3 months ago by wychen
Modified:
3 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize check_gn_headers.py for speed Process the output of 'ninja' live through the pipe rather than waiting for it to finish. Before: 20.74user 16.36system 0:24.57elapsed 151%CPU After: 16.63user 9.24system 0:13.94elapsed 185%CPU BUG=661774 Review-Url: https://codereview.chromium.org/2842513003 Cr-Commit-Position: refs/heads/master@{#466900} Committed: https://chromium.googlesource.com/chromium/src/+/6b609383cf3669b0670b567249ff868ea4b26e43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M build/check_gn_headers.py View 2 chunks +16 lines, -2 lines 0 comments Download
M build/check_gn_headers_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
wychen
PTAL
3 years, 3 months ago (2017-04-25 00:10:16 UTC) #4
Dirk Pranke
lgtm
3 years, 3 months ago (2017-04-25 00:34:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842513003/1
3 years, 3 months ago (2017-04-25 06:18:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6b609383cf3669b0670b567249ff868ea4b26e43
3 years, 3 months ago (2017-04-25 06:30:29 UTC) #10
wychen
3 years, 3 months ago (2017-04-26 04:09:00 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2844623002/ by wychen@chromium.org.

The reason for reverting is: This optimization was buggy and broke the ninja
parsing..

Powered by Google App Engine
This is Rietveld 408576698