DevTools: render continue to location as execution line instead of green dots.

DevTools: render continue to location as execution line instead of green dots.

Review-Url: https://codereview.chromium.org/2844603002
Cr-Commit-Position: refs/heads/master@{#467806}
Committed: https://chromium.googlesource.com/chromium/src/+/de456d8a5abd7f80414bec689f45e29dc9521f6a

[pfeldman, 2017-04-26 01:33:00]

pfeldman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[pfeldman, 2017-04-26 01:33:20]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[kozy, 2017-04-26 15:21:30]

lgtm

[dgozman, 2017-04-26 16:04:59]

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:829:
this._clearValueWidgetsTimer = setTimeout(this._clearValueWidgets.bind(this),
1000);
I feel like we should do similar things for all decorations.

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:830:
this._clearContinueToLocations();
This is a nested operation. That's ok?

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Popover.js (right):

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Popover.js:158: * @param
{!MouseEvent} event
Why MouseEvent? So far we used Event everywhere, and it never was a problem.

[pfeldman, 2017-04-27 21:05:05]

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:829:
this._clearValueWidgetsTimer = setTimeout(this._clearValueWidgets.bind(this),
1000);
On 2017/04/26 16:04:58, dgozman wrote:
> I feel like we should do similar things for all decorations.

Sure. textEditor operation is a good-enough tool to do that.

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:830:
this._clearContinueToLocations();
On 2017/04/26 16:04:58, dgozman wrote:
> This is a nested operation. That's ok?

Yes

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Popover.js (right):

https://codereview.chromium.org/2844603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Popover.js:158: * @param
{!MouseEvent} event
On 2017/04/26 16:04:58, dgozman wrote:
> Why MouseEvent? So far we used Event everywhere, and it never was a problem.

I'd like to pass typed event into the getRequest callback.

[pfeldman, 2017-04-27 21:05:12]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-04-27 21:06:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:40:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493327112929200,
"parent_rev": "c7c2befd794fe76f229dab8bd68026c73470d5de", "commit_rev":
"de456d8a5abd7f80414bec689f45e29dc9521f6a"}

[commit-bot: I haz the power, 2017-04-28 01:41:49]

Description was changed from

==========
DevTools: render continue to location as execution line instead of green dots.
==========

to

==========
DevTools: render continue to location as execution line instead of green dots.

Review-Url: https://codereview.chromium.org/2844603002
Cr-Commit-Position: refs/heads/master@{#467806}
Committed:
https://chromium.googlesource.com/chromium/src/+/de456d8a5abd7f80414bec689f45...
==========

[commit-bot: I haz the power, 2017-04-28 01:41:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/de456d8a5abd7f80414bec689f45...