Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/ui/Popover.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js |
| index 6c4790ab47b81557e9d79ce7d1cce6b2937b9ed5..72a911ca083a2f61c4deebf89cbd4f1a394093e6 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js |
| @@ -34,7 +34,7 @@ |
| UI.PopoverHelper = class { |
| /** |
| * @param {!Element} container |
| - * @param {function(!Event):?UI.PopoverRequest} getRequest |
| + * @param {function(!MouseEvent):?UI.PopoverRequest} getRequest |
| */ |
| constructor(container, getRequest) { |
| this._disableOnClick = false; |
| @@ -93,7 +93,7 @@ UI.PopoverHelper = class { |
| this._startHidePopoverTimer(0); |
| this._stopShowPopoverTimer(); |
| - this._startShowPopoverTimer(event, 0); |
| + this._startShowPopoverTimer(/** @type {!MouseEvent} */ (event), 0); |
| } |
| /** |
| @@ -108,7 +108,8 @@ UI.PopoverHelper = class { |
| this._stopShowPopoverTimer(); |
| if (event.which && this._disableOnClick) |
| return; |
| - this._startShowPopoverTimer(event, this.isPopoverVisible() ? this._showTimeout * 0.6 : this._showTimeout); |
| + this._startShowPopoverTimer( |
| + /** @type {!MouseEvent} */ (event), this.isPopoverVisible() ? this._showTimeout * 0.6 : this._showTimeout); |
| } |
| /** |
| @@ -154,7 +155,7 @@ UI.PopoverHelper = class { |
| } |
| /** |
| - * @param {!Event} event |
| + * @param {!MouseEvent} event |
|
dgozman
2017/04/26 16:04:58
Why MouseEvent? So far we used Event everywhere, a
pfeldman
2017/04/27 21:05:05
I'd like to pass typed event into the getRequest c
|
| * @param {number} timeout |
| */ |
| _startShowPopoverTimer(event, timeout) { |