Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2844453002: Update CM API IDL to use SecureContext (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, haraken, jam, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update CM API IDL to use SecureContext This change implements recent changes to the Credential Manager API specification that introduce the |SecureContext| extended attribute on its interfaces. Furthermore it removes |RuntimeEnabled=CredentialManager| from the interfaces following the discussion in http://crrev.com/2832813002. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/-E-O9LgsPfM/ExJ7hiY1BQAJ BUG=715077 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2844453002 Cr-Commit-Position: refs/heads/master@{#468596} Committed: https://chromium.googlesource.com/chromium/src/+/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb

Patch Set 1 #

Total comments: 6

Patch Set 2 : Comments #

Patch Set 3 : Fix test and remove base::feature #

Patch Set 4 : Remove enableCredentialManagerAPI check in old settings page #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -95 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java View 1 2 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java View 1 2 4 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/password_manager.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/password_manager.js View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_features.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html View 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-frame-errors.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/Credential.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/CredentialUserData.idl View 1 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.idl View 1 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 41 (30 generated)
Mike West
Thanks! I left some feedback inline. Also, would you mind linking to battre@'s intent thread ...
3 years, 8 months ago (2017-04-25 18:39:45 UTC) #8
jdoerrie
Dear all, please review. This CL causes the http/tests/credentialmanager/credentialscontainer-frame-errors.html test to reliably time out (https://codesearch.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-frame-errors.html), ...
3 years, 8 months ago (2017-04-26 12:20:35 UTC) #11
vasilii
Probably it can't understand if example.test:8000 is secure origin or not. I think the test ...
3 years, 8 months ago (2017-04-26 17:44:09 UTC) #12
Mike West
On 2017/04/26 at 12:20:35, jdoerrie wrote: > Dear all, please review. This CL causes the ...
3 years, 7 months ago (2017-04-27 11:18:29 UTC) #13
Mike West
third_party/WebKit LGTM, thanks!
3 years, 7 months ago (2017-04-28 07:34:48 UTC) #29
jdoerrie
Thanks, Mike! stevenjb@chromium.org: Please review changes in - chrome/browser/resources/options/password_manager.html - chrome/browser/resources/options/password_manager.js - chrome/browser/ui/webui/options/password_manager_handler.cc jochen@chromium.org: Please ...
3 years, 7 months ago (2017-04-28 08:49:55 UTC) #33
stevenjb
It looks like the credentials_enable_autosignin pref is not hidden in the new MD Settings UI? ...
3 years, 7 months ago (2017-04-28 15:44:51 UTC) #34
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-02 09:16:13 UTC) #35
jdoerrie
Thank you for the LGTMs! stevenjb@chromium.org: You are right, in the new MD settings the ...
3 years, 7 months ago (2017-05-02 09:22:15 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844453002/80001
3 years, 7 months ago (2017-05-02 09:23:44 UTC) #38
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 11:19:50 UTC) #41
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/44ca0605b598508b94a2cf0ccb4d...

Powered by Google App Engine
This is Rietveld 408576698