chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java - Issue 2844453002: Update CM API IDL to use SecureContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java

Issue 2844453002: Update CM API IDL to use SecureContext (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java ('k') | chrome/browser/about_flags.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java

index 83797d0fb30c9b1996aa0c00ccba29430a371196..c3e911612b39205493b18f07e4fd0d0b3711dc44 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java

@@ -15,9 +15,7 @@ import org.junit.runner.RunWith;

import org.chromium.base.ThreadUtils;

import org.chromium.base.test.BaseJUnit4ClassRunner;

-import org.chromium.base.test.util.CommandLineFlags;

import org.chromium.base.test.util.Feature;

-import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference;

import org.chromium.chrome.browser.preferences.ChromeSwitchPreference;

import org.chromium.chrome.browser.preferences.PrefServiceBridge;

@@ -100,7 +98,6 @@ public class SavePasswordsPreferencesTest {

@Test

@SmallTest

- @CommandLineFlags.Add("enable-features=" + SavePasswordsPreferences.CREDENTIAL_MANAGER_API)

@Feature({"Preferences"})

public void testAutoSignInCheckbox() throws Exception {

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@@ -117,8 +114,6 @@ public class SavePasswordsPreferencesTest {

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- Assert.assertTrue(ChromeFeatureList.isEnabled(

- SavePasswordsPreferences.CREDENTIAL_MANAGER_API));

SavePasswordsPreferences passwordPrefs =

(SavePasswordsPreferences) preferences.getFragmentForTest();

ChromeBaseCheckBoxPreference onOffSwitch =

@@ -145,8 +140,6 @@ public class SavePasswordsPreferencesTest {

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- Assert.assertTrue(ChromeFeatureList.isEnabled(

- SavePasswordsPreferences.CREDENTIAL_MANAGER_API));

SavePasswordsPreferences passwordPrefs =

(SavePasswordsPreferences) preferences2.getFragmentForTest();

ChromeBaseCheckBoxPreference onOffSwitch =