Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2844383003: [DevTools] Move the rest of emulation to EmulationModel (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move the rest of emulation to EmulationModel BUG=none Review-Url: https://codereview.chromium.org/2844383003 Cr-Commit-Position: refs/heads/master@{#467938} Committed: https://chromium.googlesource.com/chromium/src/+/08b31fc7c0ebd22fcdbec418fb6b7a026e87f4d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -44 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 11 chunks +39 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/EmulationModel.js View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgozman
Take a look please.
3 years, 7 months ago (2017-04-27 22:54:03 UTC) #4
pfeldman
lgtm
3 years, 7 months ago (2017-04-28 00:57:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844383003/1
3 years, 7 months ago (2017-04-28 07:57:10 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 09:11:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08b31fc7c0ebd22fcdbec418fb6b...

Powered by Google App Engine
This is Rietveld 408576698