third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js - Issue 2844383003: [DevTools] Move the rest of emulation to EmulationModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

Issue 2844383003: [DevTools] Move the rest of emulation to EmulationModel (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/EmulationModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

index d196701a38740d6631013eb197401af79e611da1..fcb502af37cf99534cc3318cbe81412eb294605e 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

@@ -452,7 +452,7 @@ Emulation.DeviceModeView = class extends UI.VBox {

* @param {!Element} canvas

_saveScreenshot(canvas) {

- var url = this._model.target() && this._model.target().inspectedURL();

+ var url = this._model.inspectedURL();

var fileName = url ? url.trimURL().removeURLFragment() : '';

if (this._model.type() === Emulation.DeviceModeModel.Type.Device)

fileName += Common.UIString('(%s)', this._model.device().title);