Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2844373002: [memory-infra] Remove thread check blacklist (Closed)

Created:
3 years, 7 months ago by ssid
Modified:
3 years, 7 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[memory-infra] Remove thread check blacklist The blacklist was introduced by crrev.com/2592233002 to make thread checks stricter. The blacklist was to throttle the number of build bot failures. There are only few providers left and it causes a need for having |is_enabled_| in MDM. So, remove this check. BUG=643438 Review-Url: https://codereview.chromium.org/2844373002 Cr-Commit-Position: refs/heads/master@{#468118} Committed: https://chromium.googlesource.com/chromium/src/+/fde86224c05a8bb41576591b31d7a2058ed32cb1

Patch Set 1 #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -59 lines) Patch
M base/trace_event/memory_dump_manager.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 3 chunks +1 line, -37 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
ssid
ptal, thanks!
3 years, 7 months ago (2017-04-27 18:26:31 UTC) #2
Primiano Tucci (use gerrit)
LGTM thanks, +hjd fyi
3 years, 7 months ago (2017-04-28 15:34:20 UTC) #10
Primiano Tucci (use gerrit)
On 2017/04/28 15:34:20, Primiano Tucci wrote: > LGTM thanks, +hjd fyi Maybe expand alittle bit ...
3 years, 7 months ago (2017-04-28 15:36:30 UTC) #11
ssid
On 2017/04/28 15:36:30, Primiano Tucci wrote: > On 2017/04/28 15:34:20, Primiano Tucci wrote: > > ...
3 years, 7 months ago (2017-04-28 18:14:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844373002/20001
3 years, 7 months ago (2017-04-28 18:16:09 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 20:42:21 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fde86224c05a8bb41576591b31d7...

Powered by Google App Engine
This is Rietveld 408576698