Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2012)

Unified Diff: base/trace_event/memory_dump_manager_unittest.cc

Issue 2844373002: [memory-infra] Remove thread check blacklist (Closed)
Patch Set: rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/memory_dump_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_manager_unittest.cc
diff --git a/base/trace_event/memory_dump_manager_unittest.cc b/base/trace_event/memory_dump_manager_unittest.cc
index 946b5b64162003adf5b997f8471f03744f7f07d7..9d2d4394235dab720fc67960faccac1cdec5dd36 100644
--- a/base/trace_event/memory_dump_manager_unittest.cc
+++ b/base/trace_event/memory_dump_manager_unittest.cc
@@ -1270,23 +1270,6 @@ TEST_F(MemoryDumpManagerTest, TestBackgroundTracingSetup) {
DisableTracing();
}
-TEST_F(MemoryDumpManagerTest, TestBlacklistedUnsafeUnregistration) {
- InitializeMemoryDumpManager(false /* is_coordinator */);
- MockMemoryDumpProvider mdp1;
- RegisterDumpProvider(&mdp1, nullptr, kDefaultOptions,
- "BlacklistTestDumpProvider");
- // Not calling UnregisterAndDeleteDumpProviderSoon() should not crash.
- mdm_->UnregisterDumpProvider(&mdp1);
-
- Thread thread("test thread");
- thread.Start();
- RegisterDumpProvider(&mdp1, thread.task_runner(), kDefaultOptions,
- "BlacklistTestDumpProvider");
- // Unregistering on wrong thread should not crash.
- mdm_->UnregisterDumpProvider(&mdp1);
- thread.Stop();
-}
-
// Tests that we can manually take a dump without enabling tracing.
TEST_F(MemoryDumpManagerTest, DumpWithTracingDisabled) {
InitializeMemoryDumpManager(false /* is_coordinator */);
« no previous file with comments | « base/trace_event/memory_dump_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698