[CrOS Tether] Add HasConnectedToHost property for Tether networks.

chromeos/network/network_state_handler.cc

Index: chromeos/network/network_state_handler.cc
diff --git a/chromeos/network/network_state_handler.cc b/chromeos/network/network_state_handler.cc
index c68b33fcdd2684b1dadf2cfef615bf0d4cbf924d..87b66896aa97cd695990f49000d0cba86a00d72b 100644
--- a/chromeos/network/network_state_handler.cc
+++ b/chromeos/network/network_state_handler.cc
@@ -531,6 +531,9 @@ void NetworkStateHandler::AddTetherNetworkState(const std::string& guid,
   tether_network_state->set_connectable(true);
   tether_network_state->set_carrier(carrier);
   tether_network_state->set_battery_percentage(battery_percentage);
+  // TODO(khorimoto): Add this field as a parameter to this function and set it
+  // accordingly from the Tether component.

[stevenjb, 2017/04/27 19:28:53]

Are we really going to want/need to pass this as a parameter? It seems like
something that would generally get set after creation.

[Kyle Horimoto, 2017/04/27 19:40:23]

I think that it makes sense to send it at the same time as the other parameters
to this function. The reason is that once we call NotifyNetworkListChanged()
below, an Observer could inspect this network and call
has_connected_as_tether_client(), receiving an incorrect value. I want the
NetworkState to be fully up-to-date before invoking any Observer callbacks.

[stevenjb, 2017/04/27 19:47:32]

Acknowledged.

+  tether_network_state->set_has_connected_as_tether_client(false);
   tether_network_state->set_signal_strength(signal_strength);
 
   tether_network_list_.push_back(std::move(tether_network_state));