[CrOS Tether] Add HasConnectedToHost property for Tether networks.

chromeos/network/network_state.h

Index: chromeos/network/network_state.h
diff --git a/chromeos/network/network_state.h b/chromeos/network/network_state.h
index 995207d3f3473da9a479eb518e4b17e46a7e0dbb..ed750fd32967621c41f278508da925672e544e37 100644
--- a/chromeos/network/network_state.h
+++ b/chromeos/network/network_state.h
@@ -114,6 +114,12 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
   }
   const std::string& carrier() const { return carrier_; }
   void set_carrier(const std::string& carrier) { carrier_ = carrier; }
+  bool has_connected_as_tether_client() const {
+    return has_connected_as_tether_client_;
+  }
+  void set_has_connected_as_tether_client(bool has_connected_as_tether_client) {
+    has_connected_as_tether_client_ = has_connected_as_tether_client;
+  }
   const std::string& tether_guid() const { return tether_guid_; }
   void set_tether_guid(const std::string& guid) { tether_guid_ = guid; }
 
@@ -229,6 +235,7 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
   // Tether properties.
   std::string carrier_;
   int battery_percentage_;
+  bool has_connected_as_tether_client_;

[stevenjb, 2017/04/27 19:28:53]

This should be documented because the name is kind of confusing. Also, it's
unclear to me why this is different from the ONC property name
(has_connected_to_host)?

[Kyle Horimoto, 2017/04/27 19:40:23]

Added explanation. The reason why I chose a slightly different name is because
it is not obvious that a has_connected_to_host() function does not apply to
other network types. For example, a future reader of this class may assume that
has_connected_to_host() would return true for a Wi-Fi NetworkState if the device
has already connected to that Wi-Fi network before. To eliminate this ambiguity,
I made sure to include the word "tether" in the name of the function.

[stevenjb, 2017/04/27 19:45:52]

How about tether_has_connected_to_host?

[Kyle Horimoto, 2017/04/27 19:51:49]

Done.

 
   // TODO(pneubeck): Remove this once (Managed)NetworkConfigurationHandler
   // provides proxy configuration. crbug.com/241775