[CrOS Tether] Add HasConnectedToHost property for Tether networks.

chromeos/network/network_state_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_state_handler.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 513 matching lines @@
 
   tether_network_state->set_name(name);
   tether_network_state->set_type(kTypeTether);
   tether_network_state->SetGuid(guid);
   tether_network_state->set_visible(true);
   tether_network_state->set_update_received();
   tether_network_state->set_update_requested(false);
   tether_network_state->set_connectable(true);
   tether_network_state->set_carrier(carrier);
   tether_network_state->set_battery_percentage(battery_percentage);
+  // TODO(khorimoto): Add this field as a parameter to this function and set it
+  // accordingly from the Tether component.

[stevenjb, 2017/04/27 19:28:53]

Are we really going to want/need to pass this as a parameter? It seems like
something that would generally get set after creation.

[Kyle Horimoto, 2017/04/27 19:40:23]

I think that it makes sense to send it at the same time as the other parameters
to this function. The reason is that once we call NotifyNetworkListChanged()
below, an Observer could inspect this network and call
has_connected_as_tether_client(), receiving an incorrect value. I want the
NetworkState to be fully up-to-date before invoking any Observer callbacks.

[stevenjb, 2017/04/27 19:47:32]

Acknowledged.

+  tether_network_state->set_has_connected_as_tether_client(false);
   tether_network_state->set_signal_strength(signal_strength);
 
   tether_network_list_.push_back(std::move(tether_network_state));
   NotifyNetworkListChanged();
 }
 
 bool NetworkStateHandler::UpdateTetherNetworkProperties(
     const std::string& guid,
     const std::string& carrier,
     int battery_percentage,
@@ skipping 874 matching lines @@
   if (type.MatchesType(shill::kTypeVPN))
     technologies.emplace_back(shill::kTypeVPN);
   if (type.MatchesType(kTypeTether))
     technologies.emplace_back(kTypeTether);
 
   CHECK_GT(technologies.size(), 0ul);
   return technologies;
 }
 
 }  // namespace chromeos