Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chromeos/network/network_configuration_handler_unittest.cc

Issue 2844363003: [CrOS Tether] Add HasConnectedToHost property for Tether networks. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_configuration_handler_unittest.cc
diff --git a/chromeos/network/network_configuration_handler_unittest.cc b/chromeos/network/network_configuration_handler_unittest.cc
index bfe347164d14e78b9bed054b587d21c9dc109b68..d07215f8b6c1822b49b6a46dcb69ce532a45b5ec 100644
--- a/chromeos/network/network_configuration_handler_unittest.cc
+++ b/chromeos/network/network_configuration_handler_unittest.cc
@@ -366,6 +366,9 @@ TEST_F(NetworkConfigurationHandlerTest, GetProperties_TetherNetwork) {
NetworkStateHandler::TechnologyState::TECHNOLOGY_ENABLED);
std::string kTetherGuid = "TetherGuid";
+ // TODO(khorimoto): Pass a has_connected_to_host parameter to this function
+ // and verify that it is present in the JSON below. Currently, it is hard-
+ // coded to false.
network_state_handler_->AddTetherNetworkState(
kTetherGuid, "TetherNetworkName", "TetherNetworkCarrier",
100 /* battery_percentage */, 100 /* signal_strength */);
@@ -380,6 +383,7 @@ TEST_F(NetworkConfigurationHandlerTest, GetProperties_TetherNetwork) {
"\"State\": \"\",\n "
"\"Tether.BatteryPercentage\": 100,\n "
"\"Tether.Carrier\": \"TetherNetworkCarrier\",\n "
+ "\"Tether.HasConnectedToHost\": false,\n "
"\"Tether.SignalStrength\": 100,\n "
"\"Type\": \"wifi-tether\"\n"
"}\n";

Powered by Google App Engine
This is Rietveld 408576698