[CrOS Tether] Add HasConnectedToHost property for Tether networks.

chromeos/network/network_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_H_
 #define CHROMEOS_NETWORK_NETWORK_STATE_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 96 matching lines @@
     return third_party_vpn_provider_extension_id_;
   }
 
   // Tether accessors and setters.
   int battery_percentage() const { return battery_percentage_; }
   void set_battery_percentage(int battery_percentage) {
     battery_percentage_ = battery_percentage;
   }
   const std::string& carrier() const { return carrier_; }
   void set_carrier(const std::string& carrier) { carrier_ = carrier; }
+  bool has_connected_as_tether_client() const {
+    return has_connected_as_tether_client_;
+  }
+  void set_has_connected_as_tether_client(bool has_connected_as_tether_client) {
+    has_connected_as_tether_client_ = has_connected_as_tether_client;
+  }
   const std::string& tether_guid() const { return tether_guid_; }
   void set_tether_guid(const std::string& guid) { tether_guid_ = guid; }
 
   // Returns true if the network securty is WEP_8021x (Dynamic WEP)
   bool IsDynamicWep() const;
 
   // Returns true if |connection_state_| is a connected/connecting state.
   bool IsConnectedState() const;
   bool IsConnectingState() const;
 
@@ skipping 95 matching lines @@
   bool cellular_out_of_credits_ = false;
 
   // VPN properties, used to construct the display name and to show the correct
   // configuration dialog.
   std::string vpn_provider_type_;
   std::string third_party_vpn_provider_extension_id_;
 
   // Tether properties.
   std::string carrier_;
   int battery_percentage_;
+  bool has_connected_as_tether_client_;

[stevenjb, 2017/04/27 19:28:53]

This should be documented because the name is kind of confusing. Also, it's
unclear to me why this is different from the ONC property name
(has_connected_to_host)?

[Kyle Horimoto, 2017/04/27 19:40:23]

Added explanation. The reason why I chose a slightly different name is because
it is not obvious that a has_connected_to_host() function does not apply to
other network types. For example, a future reader of this class may assume that
has_connected_to_host() would return true for a Wi-Fi NetworkState if the device
has already connected to that Wi-Fi network before. To eliminate this ambiguity,
I made sure to include the word "tether" in the name of the function.

[stevenjb, 2017/04/27 19:45:52]

How about tether_has_connected_to_host?

[Kyle Horimoto, 2017/04/27 19:51:49]

Done.

 
   // TODO(pneubeck): Remove this once (Managed)NetworkConfigurationHandler
   // provides proxy configuration. crbug.com/241775
   base::DictionaryValue proxy_config_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkState);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_NETWORK_STATE_H_