Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2844253004:
Generate getters/setters for VisitedLinkColor. (Closed)
DescriptionGenerate getters/setters for VisitedLinkColor.
Currently, the VisitedLinkColor property is a 'storage_only' field, so
it has no generated public getters/setters. This patch changes it to an
'external' field so that their getters/setters can be generated as well.
Diff of generated files:
https://gist.github.com/darrnshn/66f19ed3bd09d0744ffc292f3210b479/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2844253004
Cr-Commit-Position: refs/heads/master@{#473013}
Committed: https://chromium.googlesource.com/chromium/src/+/5e2a9eb0941bd44c21096357eedee2c6e4985ac2
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #
Depends on Patchset: Messages
Total messages: 31 (26 generated)
shend@chromium.org changed reviewers: + nainar@chromium.org
Hi Naina, PTAL
lgtm
rune@opera.com changed reviewers: + rune@opera.com
rs lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org, rune@opera.com Link to the patchset: https://codereview.chromium.org/2844253004/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495140267570320,
"parent_rev": "e1bd6ca3c206cf48b29523ae64bdfeca06a1e1b6", "commit_rev":
"5e2a9eb0941bd44c21096357eedee2c6e4985ac2"}
Message was sent while issue was closed.
Description was changed from ========== Generate getters/setters for VisitedLinkColor. Currently, the VisitedLinkColor property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/66f19ed3bd09d0744ffc292f3210b479/revisions BUG=628043 ========== to ========== Generate getters/setters for VisitedLinkColor. Currently, the VisitedLinkColor property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/66f19ed3bd09d0744ffc292f3210b479/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2844253004 Cr-Commit-Position: refs/heads/master@{#473013} Committed: https://chromium.googlesource.com/chromium/src/+/5e2a9eb0941bd44c21096357eede... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/5e2a9eb0941bd44c21096357eede... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
