Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2844243003: Speculative fix for crash in blink::DragData::modifiers. (Closed)

Created:
3 years, 7 months ago by paulmeyer
Modified:
3 years, 7 months ago
Reviewers:
pdr.
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, kinuko+watch, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for crash in blink::DragData::modifiers. BUG=671152 Review-Url: https://codereview.chromium.org/2844243003 Cr-Commit-Position: refs/heads/master@{#468184} Committed: https://chromium.googlesource.com/chromium/src/+/0a54e8804a182388f0aedc8a18524eaa10e76b85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/web/WebFrameWidgetBase.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
paulmeyer
3 years, 7 months ago (2017-04-28 13:18:52 UTC) #2
pdr.
On 2017/04/28 at 13:18:52, paulmeyer wrote: > LGTM
3 years, 7 months ago (2017-04-28 16:51:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844243003/1
3 years, 7 months ago (2017-04-28 17:13:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/282322)
3 years, 7 months ago (2017-04-28 20:21:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844243003/1
3 years, 7 months ago (2017-04-28 23:03:38 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 00:09:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a54e8804a182388f0aedc8a1852...

Powered by Google App Engine
This is Rietveld 408576698